Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot workflows permissions #2260

Closed
petertonysmith94 opened this issue May 8, 2024 · 7 comments · Fixed by #2295
Closed

Dependabot workflows permissions #2260

petertonysmith94 opened this issue May 8, 2024 · 7 comments · Fixed by #2295
Assignees
Labels

Comments

@petertonysmith94
Copy link
Contributor

Dependabot workflows appear to run in a less privileged state (with read only permissions).

This is causing issues where the coverage report can't be posted.

Dependabot permissions

image

source

Standard CI permissions

image

source

Originally posted by @petertonysmith94 in #2259 (comment)

@maschad
Copy link
Member

maschad commented May 8, 2024

This also affects our ability to create the changesets for the dependabot PRs as well

@arboleya
Copy link
Member

arboleya commented May 9, 2024

@maschad @petertonysmith94 Do we know what the solution is here? There may be settings I could configure in the repo.

As I mentioned in the last sync, we must address all those dependabot PRs to clear the clutter.

@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented May 9, 2024

@arboleya is there a Dependabot Secrets tab?

@maschad
Copy link
Member

maschad commented May 9, 2024

@arboleya let's pair on this to resolve it.

@maschad maschad self-assigned this May 13, 2024
@maschad
Copy link
Member

maschad commented May 13, 2024

@petertonysmith94 the dependabot PRs don't need to report coverage tbh, so we may not need to add permissions, let's as we could just disable that step for dependabot PRs

@petertonysmith94
Copy link
Contributor Author

@maschad does it not require the permissions for the create-changeset job?

@maschad
Copy link
Member

maschad commented May 14, 2024

@maschad does it not require the permissions for the create-changeset job?

That job is completed by the Github bot and so it shouldn't to the best of my knowledge, but otherwise yes we would need to add it to the secret as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants