Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sysinfo dependency behind a feature flag #4737

Closed
kayagokalp opened this issue Jul 3, 2023 · 1 comment · Fixed by #4750
Closed

Move sysinfo dependency behind a feature flag #4737

kayagokalp opened this issue Jul 3, 2023 · 1 comment · Fixed by #4750
Assignees
@kayagokalp
Labels
bug Something isn't working code quality

Comments

@kayagokalp
Copy link
Member

Since sysinfo is only needed for benchmarks we should consider moving it behind a flag. Since it causes this annoying bug we are dealing with in fuel.nix: FuelLabs/fuel.nix#64.
@kayagokalp kayagokalp added bug Something isn't working code quality labels Jul 3, 2023
@kayagokalp kayagokalp self-assigned this Jul 3, 2023
@tritao
Copy link
Contributor

tritao commented Jul 3, 2023

I think it's only being used to track memory usage, if the issue is just on Mac then I think we could disable it for Mac builds.

@kayagokalp kayagokalp mentioned this issue Jul 5, 2023
Merged
7 tasks
kayagokalp added a commit that referenced this issue Jul 5, 2023
@kayagokalp
refactor: move sysinfo behind a feature flag and only enable it for…
5dac20e 
… non-macos builds (#4750)

## Description
closes #4737.

This PR makes `sysinfo` an optional dependency which is only enabled for
non-macos builds.
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
@JoshuaBatty JoshuaBatty mentioned this issue Jul 14, 2023
Closed
@JoshuaBatty JoshuaBatty mentioned this issue Mar 1, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
bug Something isn't working code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move sysinfo behind a feature flag and only enable it for non-macos builds FuelLabs/sway
2 participants
@tritao @kayagokalp