Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a superclass for Moves and Items #738

Open
Machinocheese opened this issue May 4, 2018 · 0 comments
Open

Make a superclass for Moves and Items #738

Machinocheese opened this issue May 4, 2018 · 0 comments
Labels
Animations Battles Cleanup Good First Issue Help Wanted

Comments

@Machinocheese
Copy link
Contributor

Machinocheese commented May 4, 2018 •
edited

Bug Summary

Moves and Items (ItemsAnimations.ts) have very similar code. These classes should be consolidated, and ensure that the rest of the code is changed to match that.

Steps to Reproduce

The files are found in src/components/battles/animations/shared.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Animations Battles Cleanup Good First Issue Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @Machinocheese