Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename spark.read.dgraph.graphframes #146

Open
EnricoMi opened this issue Nov 4, 2021 · 0 comments
Open

Rename spark.read.dgraph.graphframes #146

EnricoMi opened this issue Nov 4, 2021 · 0 comments
Labels
enhancement New feature or request java Pull requests that update Java code python Pull requests that update Python code
Milestone
Version 1.0.0

Comments

@EnricoMi
Copy link
Collaborator

EnricoMi commented Nov 4, 2021 •
edited

We should rename spark.read.dgraph.graphframes to spark.read.dgraph.graphframe as the returned type is a GraphFrameand we read only a single one.

The current graphframes refers to the library name "GraphFrames" which looks strange in that call.

Do this in Scala and Python. Check the Java API as well.

The old method should be marked as deprecated and removed in release 1.0.0.

See #12.
@EnricoMi EnricoMi added enhancement New feature or request java Pull requests that update Java code python Pull requests that update Python code labels Nov 4, 2021
@EnricoMi EnricoMi added this to the Version 1.0.0 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request java Pull requests that update Java code python Pull requests that update Python code
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
1 participant
@EnricoMi