Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector layer gets exported as an empty image if using a custom color profile #55

Open
1 of 2 tasks
simonschreibt-code opened this issue Aug 13, 2021 · 6 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@simonschreibt-code
Copy link

simonschreibt-code commented Aug 13, 2021

  • Bug report.
  • Feature request.

Bug report

What is the current behavior?

Vector layer does not exported (is not visible) BUT trimming respects the bounding box of the vector text!

What is the expected behavior?

Vector layer is visible in exported PNG:

Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem.

  1. Get the file: https://www.dropbox.com/s/x8gddk0fnyw2bw8/gamejam_headlines_01.kra?dl=0
  2. Click "All Layers" in the Batch Exporter
  3. See that the file has the correct dimensions (after trimming) but the text is not readable.
@NathanLovato
Copy link
Contributor

NathanLovato commented Aug 14, 2021

That's an unsupported feature, the addon doesn't support vector layers. Note we're not actively working on it at the moment. Someone's welcome to add the feature but we won't work on it.

@NathanLovato NathanLovato changed the title Vector Layer does not get exported (but is respected for trimming) Add support for vector layers Aug 14, 2021
@NathanLovato NathanLovato added the feature Adding a new tool to the plugin label Aug 14, 2021
@simonschreibt-code
Copy link
Author

Oh, in that case I'm afraid the documentation is out of date:
Screenshot_20210814-105603_Brave

@NathanLovato NathanLovato added bug Something isn't working and removed feature Adding a new tool to the plugin labels Aug 15, 2021
@NathanLovato
Copy link
Contributor

I checked the code, and indeed we do try to export vector layers. I didn't remember that, my bad. What I'm seeing too is we rely on Krita's internal conversion mechanism, and it seems it doesn't work with text perhaps?

@razcore-rad this user has a vector layer with text and the text doesn't get rasterized when exporting the corresponding layer with batch exporter. The output image is empty. Do you know something about that?

@NathanLovato NathanLovato changed the title Add support for vector layers Vector layer gets exported as an empty image Aug 15, 2021
@razcore-rad
Copy link
Contributor

razcore-rad commented Aug 16, 2021

@iLegacy It seems like there's a problem with non-default Color Profiles. After converting your image to the default profile (Image -> Properties...):

image

I could successfully export the image:

einleitung_01


I don't know if this is an internal issue or a bug in our plugin yet.

@simonschreibt-code
Copy link
Author

simonschreibt-code commented Aug 16, 2021

@razcore-rad Thank you! Yes, you are right. When I change the color-profile to default, save the file, re-load the file and re-export with the batch exporter, it works!
Maybe it would be an idea to add a little (i) info about that in the documentation - just in case other people run into the same issue?

Thank you for the help!

@razcore-rad
Copy link
Contributor

razcore-rad commented Aug 16, 2021

Yeah, I just don't know why this is happening, cause before save we convert the image in the plugin to the default color profile as well.

We didn't document this cause we didn't know it's an issue until now.

@NathanLovato NathanLovato changed the title Vector layer gets exported as an empty image Vector layer gets exported as an empty image if using a custom color profile Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants