Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fvcore_layout.rc to FV3? #24

Open
mathomp4 opened this issue Aug 12, 2019 · 2 comments
Open

Move fvcore_layout.rc to FV3? #24

mathomp4 opened this issue Aug 12, 2019 · 2 comments
Assignees

Comments

@mathomp4
Copy link
Member

This is mainly a meta-question for @wmputman, but I've always wondered: why is fvcore_layout.rc here in GEOSgcm_App? To me it seems more suited to the FV3 directory as in most of the rest of GEOS, we keep RC files with their source code (see GOCART).

It wouldn't be too hard to change, just a file move and updates to a couple CMakeLists.txt files.

@wmputman
Copy link
Contributor

Initially I have no problems changing this location, but for certain 'apps' (like various standalone FV3 configurations and tests) we might prefer a different layout configuration.

@tclune
Copy link
Collaborator

tclune commented Aug 20, 2019

@wmputman Any 'apps' that use FV would have access to the fvcore_layout.rc file. It's just a question of where the default settings live. The actual build can still copy the resource file into whatever build/install directory the app expects to find it in

The issue goes beyond just FV. Now that the GEOSgcm app is a separate repo, we will be aggressively trying to refactor bits of the app into the components to reduce the frequency of changes that span multiple repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants