Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are DAS specific History RC tmpl files here? #290

Open
bena-nasa opened this issue Feb 9, 2022 · 2 comments
Open

Why are DAS specific History RC tmpl files here? #290

bena-nasa opened this issue Feb 9, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@bena-nasa
Copy link
Collaborator

A proposal.

  1. All the DAS specific History tmpl files should be moved out of this repository and to GEOSdas_App.
    The simple fact is that these particular templates do not work with gcm_setup (but must be processed by fv_setup) yet there is nothing to stop less experienced users from choosing these and scratching their heads when they fail.

If these are non-functional with gcm_setup it seems like they should not be here at all but rather with the GEOSdas_App and fv_setup.

Or

  1. If we want these in one place there needs to be a universal, independent script that performed the untemplating that would be used by both workflows and function in both workflows. This would be especially useful for proactive testing.
@bena-nasa bena-nasa added the question Further information is requested label Feb 9, 2022
@sdrabenh
Copy link
Collaborator

sdrabenh commented Feb 9, 2022

@bena-nasa you ask a good question. @lltakacs may have had a reason for putting these here at one point - even if just for a convenient reference. I don't know.

Regarding the question at hand, I think ultimately (2) is a better approach and something worth working toward. However, I'm unsure what resources are available in the short term in order to make that happen. Given that, I have no objection to (1). Although, most users probably rely on the gcm/fv_setup rather than digging through their install/etc dirs to find history templates. So I'm not sure how critical this is.

@bena-nasa
Copy link
Collaborator Author

@sdrabenh, I had user that was trying to use one of the DAS specific templates with gcm_setup (they must have chosen that one when running gcm_setup, I'm not exactly sure, took a while to convince them they just should not be doing this). If that was not in GEOSgcm_App at all they could have never had tried to this in the first place...
That was the motivation for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants