Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect valid range in WSUB_ExtData.yaml #849

Open
bena-nasa opened this issue Oct 26, 2023 · 2 comments
Open

Incorrect valid range in WSUB_ExtData.yaml #849

bena-nasa opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bena-nasa
Copy link
Collaborator

bena-nasa commented Oct 26, 2023

A user trying to run the 2 moment micro physics at NAS was having some troubles in ExtData. Turns out the issue was that the "valid range" in this file is wrong for the dataset (note user is using the same data but obviously had to change the path since this is hard coded for discover still):
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/develop/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/WSUB_ExtData.yaml

To quote what is there now:

Collections:
  WSUB_SWclim_2005%m2.nc4:
    template: /discover/nobackup/dbarahon/DEV/SWclim/L72/SWclim_2005%m2.nc4
    valid_range: "2005-01-01/2005-12-31"

That valid range is wrong, the dataset is only valid through 2005-12-01 so it should be changed to this:

Collections:
  WSUB_SWclim_2005%m2.nc4:
    template: /discover/nobackup/dbarahon/DEV/SWclim/L72/SWclim_2005%m2.nc4
    valid_range: "2005-01-01/2005-12-01"
@bena-nasa bena-nasa added the bug Something isn't working label Oct 26, 2023
@dbarahon
Copy link
Contributor

dbarahon commented Oct 30, 2023 via email

@bena-nasa
Copy link
Collaborator Author

@dbarahon yes, please make a PR to fix this. It is simply the wrong valid range, please update to what I said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants