Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up source code after disabling of CatchCNCLM45 land model option #907

Open
gmao-rreichle opened this issue Feb 21, 2024 · 0 comments
Open

clean up source code after disabling of CatchCNCLM45 land model option #907

gmao-rreichle opened this issue Feb 21, 2024 · 0 comments
Assignees
@gmao-jkolassa
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup

Comments

@gmao-rreichle
Copy link
Contributor

The CatchmentCNCLM45 model is no longer supported and was disabled in the following PRs:
#900
GEOS-ESM/GEOSgcm_App#575
GEOS-ESM/GEOSldas#707
These changes should make it impossible to run CatchmentCNCLM45, but the source code for this model is still present in the repository. A more thorough cleanup is needed. The best time to address this cleanup is probably when the new version Catchment+CTSM5.1 is merged.
@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels Feb 21, 2024
@gmao-rreichle gmao-rreichle mentioned this issue Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmao-jkolassa gmao-jkolassa

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmao-rreichle @gmao-jkolassa