Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After chip completion, new chip contains previous chip's values #959

Open
dougse opened this issue Aug 11, 2020 · 1 comment
Open

After chip completion, new chip contains previous chip's values #959

dougse opened this issue Aug 11, 2020 · 1 comment

Comments

@dougse
Copy link

dougse commented Aug 11, 2020

PLEASE MAKE SURE THAT:

  • you searched similar issues online (9/10 issues in this repo are solved by googling, so please...do it)
  • you provide an online demo I can see without having to replicate your environment
  • you help me by debugging your issue, and if you can't, do go on filling out this form

I'm submitting a ... (check one with "x")

[X ] bug report => search github for a similar issue or PR before submitting
[ ] support request/question

Notice: feature requests will be ignored, submit a PR if you'd like

Current behavior

When typing chips quickly, and creating a new chip by hitting "Enter", sometimes new chip text area contains prior chip value.

Expected behavior

Never offer a duplicate chip value.

Minimal reproduction of the problem with instructions (if applicable)

What do you use to build your app?. Please specify the version

Angular version:

Current master

ngx-chips version:

Current maste

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

All
dougse pushed a commit to dougse/ngx-chips that referenced this issue Aug 17, 2020
Resolves
b9967df 
Gbuomprisco#959 - After chip completion, new chip contains previous chip's values
Gbuomprisco#945 - Adding tags very quickly causes error expressionChangedAfterItHasBeenCheckedError
Gbuomprisco#953 - (PERHAPS) Validating using formControlName does not work
@dougse dougse mentioned this issue Aug 17, 2020
Open
@mustafa-alsuhaibi
Copy link

I have this problem too, still not fixed!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougse @mustafa-alsuhaibi