Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Look into issue in spec with DataSource #1492

Open
benjamincharity opened this issue May 7, 2019 · 0 comments
Open

Table: Look into issue in spec with DataSource #1492

benjamincharity opened this issue May 7, 2019 · 0 comments
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on P4: Nice to Have Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

There is a TODO comment stating that TypeScript was unhappy when using our version of DataSource so the spec file uses the CDK version. We should get to the bottom of this issue if still valid so that our spec goes forward using the same version of DataSource as our consumers will.

https://github.com/GetTerminus/terminus-ui/blob/cc9d398591a5e398f7f02b73d1c3248c442eda83/terminus-ui/table/src/table.component.spec.ts
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on P4: Nice to Have Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels May 7, 2019
@benjamincharity benjamincharity mentioned this issue May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on P4: Nice to Have Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamincharity