Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS Tests - Fail, no visual difference #1531

Open
shani-terminus opened this issue Jun 5, 2019 · 0 comments
Open

SCSS Tests - Fail, no visual difference #1531

shani-terminus opened this issue Jun 5, 2019 · 0 comments
Labels
Focus: testing Tests or test helpers Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@shani-terminus
Copy link
Contributor

shani-terminus commented Jun 5, 2019 •
edited

The lerp-shadow test in _spacing.spec.scss fails with the message "Compared values have no visual difference."

Determine a way to make the test pass.

Note: this also affects the calculate-shadow-set-at-depth tests which call lerp-shadow
@benjamincharity benjamincharity added Focus: testing Tests or test helpers Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition Needs: exploration Issues that need more information before being worked on labels Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: testing Tests or test helpers Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus