Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators: Custom LinkedIn Form validator #1571

Open
3 tasks
benjamincharity opened this issue Jun 24, 2019 · 1 comment
Open
3 tasks

Validators: Custom LinkedIn Form validator #1571

benjamincharity opened this issue Jun 24, 2019 · 1 comment
Labels
Focus: utility Helpers etc. Needs: feedback Issues that need feedback from one or more stakeholders Status: on hold Issues we will not address in the immediate future Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jun 24, 2019

This feature is needed for LinkedIn Forms.

We need a custom validator that product can use with the LinkedIn form selection dropdown. In this case, we need to validate a specific property exists on the selection.

  • Check selection for a top level property COMPANY_NAME using the isUnset helper
    • If found, control is valid
    • If not found, the error message Form must have Company Name as an attribute should be returned

NOTE: Ideally this would be a more generic validator that could check for one or more properties existence. But since we currently have a limitation on custom validation messages we need to make this specific for LinkedIn in order to support the correct message.

Resources

@benjamincharity benjamincharity added Focus: utility Helpers etc. Needs: feedback Issues that need feedback from one or more stakeholders Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist Status: on hold Issues we will not address in the immediate future labels Jun 24, 2019
@benjamincharity
Copy link
Contributor Author

Need feedback from the core team before we know if this is a viable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: utility Helpers etc. Needs: feedback Issues that need feedback from one or more stakeholders Status: on hold Issues we will not address in the immediate future Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Development

No branches or pull requests

1 participant