Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore commits not tied to a release do not get added to the changelog #1602

Open
benjamincharity opened this issue Jul 15, 2019 · 0 comments
Assignees
Labels
Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

1. What is the expected behavior?

All commits should be added to the changelog.

2. What is the current behavior?

Chore commits seem to not be added if not commited with code that triggers a release.

3. What are the steps to reproduce?

Providing a reproduction is the best way to share your issue.

a) Create a chore commit and push it to master
b) Notice no changelog changes are published (which is correct).
c) Create another chore commit and then a fix commit.
d) Releasing the code, you will see both commits from step 'c' but not the commit from step 'a'.

Example:

These commits:

Screen Shot 2019-07-15 at 7 57 43 AM

Created this changelog (notice missing commits for the toggle chore and log in chore):

Screen Shot 2019-07-15 at 7 57 55 AM

4. Which versions of this library, Angular, TypeScript, & browsers are affected?

  • UI Library: latest
@benjamincharity benjamincharity added Type: bug An implemented item with undesired effects Needs: exploration Issues that need more information before being worked on Target: latest Issues related to the latest version of the library (master) Goal: Library Stabilization A task needed to get the library closer to it's final state labels Jul 15, 2019
@benjamincharity benjamincharity self-assigned this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Goal: Library Stabilization A task needed to get the library closer to it's final state Needs: exploration Issues that need more information before being worked on Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Development

No branches or pull requests

1 participant