Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple: Abstract styles out to be reusable #1653

Open
3 tasks
benjamincharity opened this issue Aug 22, 2019 · 0 comments
Open
3 tasks

Ripple: Abstract styles out to be reusable #1653

benjamincharity opened this issue Aug 22, 2019 · 0 comments
Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

We are now overwriting ripple styles manually in multiple places. We should abstract the ripple style control out into a reusable mixin or set of classes.

Used in:

  • copy component
  • icon button
  • ?

  • Abstract styles out
  • Replace all manually set styles with abstraction
  • Verify all ripples are displayed as expected
@benjamincharity benjamincharity added Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Development

No branches or pull requests

1 participant