Skip to content

[Improvement] Report xml file location when xml parsing fails #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chhh opened this issue Aug 26, 2022 · 2 comments · Fixed by #3179
Closed

[Improvement] Report xml file location when xml parsing fails #3178

chhh opened this issue Aug 26, 2022 · 2 comments · Fixed by #3179
Milestone

Comments

@chhh
Copy link

chhh commented Aug 26, 2022

Is your improvement request related to a problem? Please describe.
I was confused when in a solution with 20+ projects I ran gitversion and got an XmlException printed that didn't mention the exact file that was causing problems. And 100 lines of git log were printed in addition.

Detailed Description

I was trying to update csproject filesin a solution with 20+ projects. I ran gitversion and got an XmlException printed that didn't mention the exact file that was causing problems. At this point I had no idea what files gitversion was even trying to parse that made it fail.

Context

Updating version info in multiple csproject files in a large solution.

Possible Implementation

Simply wrap xml reading call in try/catch and add file location in XmlException message.

@arturcic
Copy link
Member

Closed by #3179

@arturcic arturcic modified the milestones: 5.x, 5.11.0 Nov 7, 2022
@arturcic
Copy link
Member

arturcic commented Nov 7, 2022

🎉 This issue has been resolved in version 5.11.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants