-
Notifications
You must be signed in to change notification settings - Fork 652
[Improvement] Don't consider tag-prefix
as optional
#3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fixed by #3208 |
Is this available for use yet? If not, do you know when the next release is planned for? I've also encountered this issue where I am trying to use GitVersion in a repo that already has a bunch of non-prefixed tags used for other things. I want my GitVersion-ing to be independent of these other tags. I need the tag-prefix to be enforced rather than optional so I can ignore all the older tags and only focus on new tags prefixed with whatever I want to prefix with. |
This will be a part of our next release of v5, @andyfurniss4. We haven't planned one yet, but we do them fairly regularly. |
Thanks @asbjornu |
🎉 This issue has been resolved in version 5.11.0 🎉 Your GitReleaseManager bot 📦🚀 |
Detailed Description
Currently
tag-prefix
is always considered as optional which makes calculation of the next version incorrect. It mixes prefixed and unprefixed versions and takes the largest of both.Context
To correctly calculate the next version with the prefix. For example, we develop the main product and some its plugin in the same repository and have the following git tags list:
The expected next plugin version is 0.1.2 not 0.2.2 (plugin_ prefix will be prepended before setting the tag).
Possible Implementation
The text was updated successfully, but these errors were encountered: