Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Mute to use built-in Timeouts #229

Closed
5 tasks done
Glazelf opened this issue Nov 26, 2021 · 0 comments · Fixed by #240
Closed
5 tasks done

Refactor Mute to use built-in Timeouts #229

Glazelf opened this issue Nov 26, 2021 · 0 comments · Fixed by #240
Assignees
@Glazelf
Labels
bug Something isn't working enhancement New feature or request optimization Code optimization end users will not/barely notice

Comments

@Glazelf
Copy link
Owner

Glazelf commented Nov 26, 2021 •
edited

Time Out will make custom mute functionality redundant, but the command can still be usefull as a shortcut.

  • Use timeouts instead of adding/removing roles.
  • Remove redundant code.
  • Check if removing a timeout can be done programmatically.
  • Decide if mute shouldn't be deprecated altogether. (It shouldn't)
  • On time out add and remove events give/remove "Muted" role. (But only in SAC?)
@Glazelf Glazelf added the enhancement New feature or request label Nov 26, 2021
@Glazelf Glazelf self-assigned this Nov 26, 2021
@Glazelf Glazelf added bug Something isn't working optimization Code optimization end users will not/barely notice labels Dec 12, 2021
@Glazelf Glazelf linked a pull request Dec 12, 2021 that will close this issue
User Banner --> Member Banner #237
Closed
@Glazelf Glazelf removed a link to a pull request Dec 12, 2021
User Banner --> Member Banner #237
Closed
@Glazelf Glazelf mentioned this issue Dec 12, 2021
Merged
@Glazelf Glazelf changed the title Refactor Mute to use built-in Time Outs Refactor Mute to use built-in Timeouts Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glazelf Glazelf

Labels
bug Something isn't working enhancement New feature or request optimization Code optimization end users will not/barely notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor mutes to use timeouts Glazelf/NinigiBot
1 participant
@Glazelf