You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
String values seem to be passed by value rather than reference even though arrays are passed by reference.
Added a local array and re-populated it to fix
That is super weird. I will have to look into this closer. Very interesting. Thanks for submitting it! Will probably merge it soon, just haven't had time lately to validate it or anything.
Closing this per my comment on #350 - 4.x should be fixed permanently now, and I'm going to attempt the same refactor for 3.x, which should fix this as well I think.
Describe the bug
Passing an array to FirestoreQuery.select doesn't format the query request to Firestore properly and results in a 400
To Reproduce
Assuming a Firestore collection stage with fields name and rating:
Running:
Results in a 400 response by Firestore
Expected behavior
should request Firestore with
{fields:[{fieldPath:name}, {fieldPath:rating}]}
instead of{fields:[name, rating]}
Screenshots
Not applicable
Environment:
Additional context
I will be submitting a PR with a fix
The text was updated successfully, but these errors were encountered: