Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement input mirroring for OT milestone fields #3173

Open
DanielRyanSmith opened this issue Jul 16, 2023 · 3 comments · May be fixed by #3731
Open

Reimplement input mirroring for OT milestone fields #3173

DanielRyanSmith opened this issue Jul 16, 2023 · 3 comments · May be fixed by #3731

Comments

@DanielRyanSmith
Copy link
Collaborator

After #3162 has landed, the OT milestone fields on the stage edit page will no longer mirror their input into the other start and end fields if there is no existing value in those inputs. A special handler will need to be created to reimplement this input mirroring in a way that designates the other input fields as "touched" for form submission.

@GabriellaMSanchez
Copy link

Hello @DanielRyanSmith, I am interested in assisting with this issue. I am understanding this request as adding the functionality to mirror OT milestone field values back into other input fields in the stage edit page in a way that is functional with the new implementation of form submission and tracking "touched" fields, is that the full scope of this issue?

Please let me know if you have any other requests/desired functionality or any perspective that I might be missing to begin tackling this issue.

@DanielRyanSmith
Copy link
Collaborator Author

Hi @GabriellaMSanchez - yes, feel free to take a shot at this issue. 🙂

The basic premise we are looking for is this:

  • If the value in the text box for the OT desktop milestone start field is changed, and the other android/webview milestone start fields are empty or were the same value as the desktop milestone previously, their values are also changed to match.
  • If this value mirroring occurs, the touched property on these fields are all changed to "true" (which is how we know to update the field once the form is submitted).
  • Same for the "end" milestone fields as well.

Screenshot 2024-01-08 at 2 37 42 PM

This will likely require special logic for the ot-milestone-desktop-start and ot-milestone-desktop-end fields in the handler for updating the form field values. Let us know if you have any additional questions!

@GabriellaMSanchez
Copy link

@DanielRyanSmith Awesome, I'll reach out if there is anything additional. Thanks for the response!

mikezzb added a commit to mikezzb/chromium-dashboard that referenced this issue Mar 22, 2024
@mikezzb mikezzb linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants