Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store rollout_milestone field in the milestones field in Stage entities #3767

Open
DanielRyanSmith opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels

Comments

@DanielRyanSmith
Copy link
Collaborator

Almost all references to milestone fields are stored in Stage.milestones, which uses the MilestoneSet kind. The exception for this is rollout_milestone for enterprise features, which is a separate field from an older implementation with the milestone field unnecessarily separate from similar milestone references. Migrating this rollout_milestone field to instead live in the milestones field (as milestones.desktop_first), will consolidate this milestone field to be handled the same way all other milestone fields are.

@jrobbins
Copy link
Collaborator

jrobbins commented Apr 4, 2024

Daniel addressed this in PR #3771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants