Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The assets folder in node_modules/@lhci/server/dist disappears after modules are pruned by node-prune #969

Open
VoloshinS opened this issue Nov 8, 2023 · 0 comments

Comments

@VoloshinS
Copy link

Describe the bug
The assets folder in node_modules/@lhci/server/dist disappears after modules are pruned by node-prune.

To Reproduce
Steps to reproduce the behavior:

  1. Install @lhci/server into a project.
  2. Run npx node-prune ./node_modules.
  3. Check node_modules/@lhci/server/dist folder.

Expected behavior
node_modules/@lhci/server/dist contains assets folder.

Actual behavior
node_modules/@lhci/server/dist doesn't contain assets folder.

Additional context
It is obviously happening, because there are no direct imports from assets folder, so node-prune considers this folder unnecessary and removes it.

Issue was created rather for anyone who ended up in debugging why fonts and images are not displayed for deployed server. Not sure if many people have in their build process node-prune command, which may cause this unexpected situation.
So feel free to close, if you think no actions are needed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant