Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken in Node 15 #11673

Closed
brendankenny opened this issue Nov 16, 2020 · 0 comments · Fixed by #11676
Closed

Build is broken in Node 15 #11673

brendankenny opened this issue Nov 16, 2020 · 0 comments · Fixed by #11676

Comments

@brendankenny
Copy link
Member

manifests as

node:internal/fs/utils:627
    throw new ERR_INVALID_ARG_TYPE(propName, ['string', 'Buffer', 'URL'], path);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined

fix is up in what I believe is the repo for @wardpeet/brfs: wardpeet/brfs#1
(let me know if that's not actually the repo, @wardpeet :)

tl;dr: static-module/brfs rely on errors thrown from trying to do fs.createReadStream(undefined) to decide not to replace code with an inlined string, but fs.createReadStream behavior changed in Node 15 and the error thrown on undefined doesn't happen until later (when pipe() or whatever runs), and so static-module is no longer catching it and it's spoiling the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants