Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's going on with Chromium size, it has grown three times in the latest minor release (1.17.0 -> 1.18.0) #4610

Closed
limonte opened this issue Jun 21, 2019 · 8 comments · Fixed by #4626
Closed

What's going on with Chromium size, it has grown three times in the latest minor release (1.17.0 -> 1.18.0) #4610

limonte opened this issue Jun 21, 2019 · 8 comments · Fixed by #4626
Labels
bug chromium Issues with Puppeteer-Chromium upstream

Comments

@limonte
Copy link

limonte commented Jun 21, 2019 •
edited

I'm trying to install puppeteer on Linux and was shocked by the Chromium size:

npm i puppeteer@1.17.0

Downloading Chromium r662092 - **111.6 Mb**
npm i puppeteer@1.18.0

Downloading Chromium r669486 - **347.1 Mb**

Is Chromium growing so rapidly or is it a bug?
@limonte limonte changed the title What's going on with Chromium size, it has grown three times since 1.0.0 What's going on with Chromium size, it has grown three times in the latest minor release (1.17.0 -> 1.18.0) Jun 21, 2019
@sudofox
Copy link

sudofox commented Jun 21, 2019

Yeah, I was wondering the same thing. Redeploying something using Puppeteer and Chromium is now over one-third of a GB in size

@aslushnikov
Copy link
Contributor

Whoa, that's a bug!

@aslushnikov aslushnikov added bug chromium Issues with Puppeteer-Chromium upstream labels Jun 21, 2019
@aslushnikov
Copy link
Contributor

Filed at https://bugs.chromium.org/p/chromium/issues/detail?id=977716

@limonte
Copy link
Author

limonte commented Jun 22, 2019 •
edited

Thank you @aslushnikov!

As I can see the reported issue is already fixed.

I have an offtopic question: since you work in Google do you maybe know why isn't Chromium repo on Github? I mean GitHub is the "default" place to collaborate on software. The current UI for Chromium's bug-tracker looks terrible (in my eyes) and I personally can't figure out what's happening with repo and therefore can't contribute.

@stevenvachon
Copy link

stevenvachon commented Jun 24, 2019 •
edited

It's been running Travis CI out of memory too. Reverting to 1.17.0 fixes it.

@econner econner mentioned this issue Jun 25, 2019
Closed
@econner
Copy link

econner commented Jun 25, 2019

It also is causing slug sizes on Heroku to be too large if you run puppeteer there. Confirm that reverting to 1.17.0 also fixes it.

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jun 25, 2019
@aslushnikov
feat(chromium): roll Chromium to r672088
14c9d53 
This roll includes:
- https://crrev.com/671499 - Build with symbol_level=0 for linux-archive-rel

Fix puppeteer#4610
@aslushnikov aslushnikov mentioned this issue Jun 25, 2019
Merged
aslushnikov added a commit that referenced this issue Jun 26, 2019
@aslushnikov
feat(chromium): roll Chromium to r672088 (#4626)
cf34583 
This roll includes:
- https://crrev.com/671499 - Build with symbol_level=0 for linux-archive-rel

Fix #4610
@wavded
Copy link

wavded commented Jun 26, 2019

Same issue, reverting to 1.17.0 fixed it for me too.

@aslushnikov
Copy link
Contributor

We released v1.18.1 with the fix for the bug.

Sorry for this regression!

@snyk-bot snyk-bot mentioned this issue Oct 3, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 4, 2019
Open
This was referenced Feb 3, 2020
Open
Open
This was referenced Feb 22, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 13, 2020
Merged
@snyk-bot snyk-bot mentioned this issue May 5, 2020
Open
@eoinkelly eoinkelly mentioned this issue Sep 13, 2020
Closed
@ironicbrew ironicbrew mentioned this issue May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug chromium Issues with Puppeteer-Chromium upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(chromium): roll Chromium to r672088 aslushnikov/puppeteer
6 participants
@wavded @stevenvachon @econner @aslushnikov @sudofox @limonte