-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the INP duration threshold #103
Comments
Makes sense to me. Pasting a bit more context here from prior conversations:
There could be value to doing both of the above, the the latter seems easier, more valuable, and less risky. So, filed GoogleChrome/web-vitals#228 |
GoogleChrome/web-vitals#228 is fixed and so now first input now always counts as an INP score. There's more follow-up there chrome-side to change the reporting of FID, but I think if we just update the web-vitals library this issue will get a lot better. I did also benchmark PO (this issue) and found that the there is no measurable overhead that I could find... but even adding something like a console.log can change to affect perf, and saving state from callbacks can affect things link GC. All that said, probably having DevTools perf panel open is a much larger effect on perf itself than this extension :) |
Looks to be resolved. |
INP currently shows as "waiting for input" even after interacting with the page, if the interaction latency is sufficiently small. As a result, we show data for FID, but not INP. This might throw people off, so look into lowering the reporting threshold for INP events in web-vitals.js.
We could lower the default threshold or let developers choose a threshold in the extension options to balance reporting with performance.
cc @philipwalton @mmocny
The text was updated successfully, but these errors were encountered: