Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for getEntriesByName in performance before calling #158

Merged
merged 1 commit into from Jun 2, 2021
Merged

check for getEntriesByName in performance before calling #158

merged 1 commit into from Jun 2, 2021

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Jun 2, 2021

Resolves #159

Fixes the web-vitals package breaking applications in Opera Mini.

getEntriesByName is not supported in some version of Opera.

First reported here bbc/simorgh#9153

@google-cla
Copy link

google-cla bot commented Jun 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@philipwalton
Copy link
Member

philipwalton commented Jun 2, 2021

Thanks! Can you sign the CLA so I can merge? Otherwise I'm happy to just make the change myself. Either way :)

@jroebu14
Copy link
Contributor Author

jroebu14 commented Jun 2, 2021

@googlebot I signed it!

@philipwalton philipwalton merged commit 1804835 into GoogleChrome:master Jun 2, 2021
@philipwalton
Copy link
Member

Thanks!

@jroebu14
Copy link
Contributor Author

jroebu14 commented Jun 2, 2021

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getEntriesByName is not supported in some versions of Opera
2 participants