Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reported TTFB values are less than the current page time #187

Merged
merged 1 commit into from Oct 11, 2021

Conversation

philipwalton
Copy link
Member

Fixes #162

This PR adds a check before reporting TTFB to make sure the value isn't larger than the current value of performance.now(). This shouldn't be possible, but we've received multiple reports of it happening in the wild, so this check should help prevent reporting obviously-incorrect values.

@philipwalton philipwalton merged commit 0020d02 into main Oct 11, 2021
@philipwalton philipwalton deleted the invalid-ttfb branch October 11, 2021 22:39
@philipwalton philipwalton changed the title Ensure reported values are less than page time Ensure reported TTFB values are less than the current page time Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Best way for filtering extremely large values ?
1 participant