Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workbox-build): make source map filename consistent with injected source file #3234

Open
wants to merge 1 commit into
base: v7
Choose a base branch
from
Open

fix(workbox-build): make source map filename consistent with injected source file #3234

wants to merge 1 commit into from

Conversation

steverep
Copy link

Fixes #3233 per comments on #2239

  • Name the output source map simply swDest with .map appended
  • Replace the sourceMappingURL comment with the new filename
  • Adjust tests to use different filenames for input and output
  • Add simple test to check URL replacement

@steverep
Copy link
Author

@jeffposnick would it be possible to get your review here? I just don't want to build a pipeline using this patch if you feel it's a no go.

@jeffposnick
Copy link
Contributor

CC: @tropicadri and @petele for guidance.

@steverep
Copy link
Author

At this point I'm wondering if workbox is even being maintained anymore? It hasn't been touched in 6 months even for just responding to issues and dependency bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source map support for injectManifest makes incorrect assumptions
2 participants
@steverep @jeffposnick