Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the version of xml-2-js in bubblewrap cli package to eliminate the vulnerability #779

Open
ahmetcetin39 opened this issue Apr 11, 2023 · 2 comments

Comments

@ahmetcetin39
Copy link

ahmetcetin39 commented Apr 11, 2023

We are using @bubblewrap/cli@1.19.1 which brings xml2js inside and our dependabot raised the issue below.

The latest possible version that can be installed is 0.4.23 because of the following conflicting dependency:
@bubblewrap/cli@1.19.1 requires xml2js@^0.4.5 via a transitive dependency on parse-bmfont-xml@1.1.4
The earliest fixed version is 0.5.0.

xml2js versions before 0.5.0 allows an external attacker to edit or add new properties to an object. This is possible because the application does not properly validate incoming JSON keys, thus allowing the proto property to be edited.

Releasing a newer version of bubblewrap/cli will help users to avoid this security concern.

@andreban
Copy link
Member

This dependency is brought in via jimp, and the latest 0.22.7 version is not yet using xml2js@0.5.x

@andreban
Copy link
Member

This is blocked on jimp-dev/jimp#1223, which is blocked on mattdesl/parse-bmfont-xml#4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants