Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF viewer (swapped) inner frame should not be surfaced in WebDriver BiDi #2175

Open
OrKoN opened this issue Apr 30, 2024 · 1 comment
Open

PDF viewer (swapped) inner frame should not be surfaced in WebDriver BiDi #2175

OrKoN opened this issue Apr 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Apr 30, 2024

Those frames are replaced with an extension web view, so CDP instrumentation is not quite correct. In general, we probably do not want to expose parts of the browser UI here.

The test https://github.com/puppeteer/puppeteer/pull/12370/files
The failure https://github.com/puppeteer/puppeteer/actions/runs/8892778668/job/24417614017?pr=12370
@OrKoN OrKoN added the bug Something isn't working label Apr 30, 2024
@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 30, 2024

cc @sadym-chromium @Lightning00Blade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OrKoN