Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output size difference is always the same size as actual output #17

Open
stevenfitzpatrick opened this issue Sep 20, 2018 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@stevenfitzpatrick
Copy link

stevenfitzpatrick commented Sep 20, 2018

Hi,

Love the idea of this plugin ! Has anybody got it working ?

For me the output of the plugin is always the same the actual file size output, i.e. it never compares with previous builds

I.e. sample output

vendors~admin~create-bet~login.bundle.9aa89c670076013d8fb7.js ⏤  20.9 kB (+20.9 kB)
                                                      main.css ⏤  2.18 kB (+2.18 kB)
                           main.bundle.ca78aa7c8d6b80d6a794.js ⏤  8.28 kB (+8.28 kB)
                                                         2.css ⏤  107 B (+107 B)
                      dashboard.bundle.c2606a256910c68c213f.js ⏤  1.17 kB (+1.17 kB)
                     create-bet.bundle.3b2e0767f6308ec7e4ca.js ⏤  1.23 kB (+1.23 kB)
                                                         4.css ⏤  205 B (+205 B)
                          admin.bundle.5740df303ba85130515a.js ⏤  3.02 kB (+3.02 kB)
                          login.bundle.96773d2bb3d6c67df42a.js ⏤  1.04 kB (+1.04 kB)
                   vendors~main.bundle.73fbc0215d9b89852b15.js ⏤  149 kB (+149 kB)
                                                    index.html ⏤  541 B (+541 B)

And here is my sample webpack config :

https://github.com/stevenfitzpatrick/mybettingslips/blob/master/build-utils/webpack.prod.js

And yes I tried to change the order of the size plugin putting it first / last always same result.

@MartinCerny-awin
Copy link

I have the same issue. I would expect plugin to create some file which is used to compare the size, but nothing like this is happening.

@developit
Copy link
Collaborator

Are you using a plugin to clear your output directory? If so, that will break this plugin.

#6 provides a way forward that would circumvent this issue.

@developit developit added the enhancement New feature or request label Dec 6, 2018
@MartinCerny-awin
Copy link

Yes, @developit I am using rimraf I think this issue could be closed in favour of #6

@developit
Copy link
Collaborator

developit commented Dec 11, 2018

Looks like this might also be related to [chunkhash], which I just added support for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants