Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] unwanted **size-plugin.json** file #28

Closed
jimblue opened this issue Aug 23, 2019 · 10 comments · Fixed by #30 · May be fixed by #27
Closed

[BUG] unwanted **size-plugin.json** file #28

jimblue opened this issue Aug 23, 2019 · 10 comments · Fixed by #30 · May be fixed by #27

Comments

@jimblue
Copy link

jimblue commented Aug 23, 2019 •
edited

Hello,

Since latest release 2.0.0 a size-plugin.json file is created.
Passing option writeFile: false doesn't help to prevent that.

I guess this is bug introduced with the new release as I nothing change on my side.

Cheers :)
kuldeepkeshwar added a commit to kuldeepkeshwar/size-plugin that referenced this issue Aug 24, 2019
@kuldeepkeshwar
fixes GoogleChromeLabs#28 & remove pull_request_number
191cb2a
@jimblue
Copy link
Author

jimblue commented Aug 28, 2019

Just a friendly ping... have you been able to reproduce the bug on your side?

@kuldeepkeshwar kuldeepkeshwar mentioned this issue Sep 2, 2019
Open
@kuldeepkeshwar
Copy link
Contributor

@jimblue yup, it was my mistake.
fixed in #27

@jimblue
Copy link
Author

jimblue commented Sep 2, 2019

Hope this can be merge soon :) thank you

@developit developit mentioned this issue Oct 18, 2019
Merged
@developit
Copy link
Collaborator

@jimblue for now I've published a patch update (2.0.1) that fixes writeFile:false so it doesn't write the file.

@jimblue
Copy link
Author

jimblue commented Oct 18, 2019

awesome tks @developit

@sectsect
Copy link

This problem have resolved?
The option writeFile: false still create a size-plugin.json file on v2.0.1.

@jimblue
Copy link
Author

jimblue commented Oct 23, 2019 •
edited

Indeed @sectsect is right, I just tried with version 2.0.1... not resolved!

@jimblue
Copy link
Author

jimblue commented Oct 23, 2019

@developit can you reopen this issue please

@jimblue
Copy link
Author

jimblue commented Nov 15, 2019

@developit ?

@sectsect
Copy link

@developit
Can you reopen this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@developit @sectsect @kuldeepkeshwar @jimblue