Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'reactHotLoaderGlobal' is not defined #46

Open
sjsakib opened this issue Nov 16, 2019 · 1 comment
Open

'reactHotLoaderGlobal' is not defined #46

sjsakib opened this issue Nov 16, 2019 · 1 comment
Labels
help wanted Extra attention is needed upstream The issue is controlled by an upstream dependency

Comments

@sjsakib
Copy link

sjsakib commented Nov 16, 2019

I was using this plugin successfully with Gatsby version 2.7.5. But when I tried to upgrade Gatsby to 2.17.15 I'm getting this error.

/home/sakib/codes/personal/blog/src/posts/may-2019/SlidingPuzzle/main.worker.js
  6:5   warning  '__signature__' is assigned a value but never used  no-unused-vars
  6:67  error    'reactHotLoaderGlobal' is not defined               no-undef

I'm not sure whats going on. Is it possible that gatsby and worker-plugin is using different configuration for compiling?

@developit
Copy link
Collaborator

@sjsakib it's strange that you would be getting an ESLint error on generated output.

Gatsby needs to configure react-hot-loader to only be applied to the main Compilation. It appears they are applying it to all contexts, which breaks this plugin and likely many others.

@developit developit added the help wanted Extra attention is needed label Jan 4, 2020
@developit developit added the upstream The issue is controlled by an upstream dependency label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed upstream The issue is controlled by an upstream dependency
Projects
None yet
Development

No branches or pull requests

2 participants