Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GoogleCloudPlatform/appengine-java-standard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.9
Choose a base ref
...
head repository: GoogleCloudPlatform/appengine-java-standard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.10
Choose a head ref

Commits on Oct 17, 2022

  1. Refactor UPRequest and UPResponse translation for reusability

    PiperOrigin-RevId: 481647516
    Change-Id: I7716a44554eeab42f5ed54f56a65db183468a91d
    gae-java-bot committed Oct 17, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    54be42b View commit details
  2. Add test for UPRequest and UPResponse translation

    PiperOrigin-RevId: 481656085
    Change-Id: I28ecaae64d5cb676b60139b72d66d64f534e92a0
    gae-java-bot committed Oct 17, 2022
    Copy the full SHA
    75c5b2f View commit details
  3. Make JettyServerConnectorWithReusePort public

    PiperOrigin-RevId: 481660628
    Change-Id: Idd9093854dc2c99c16a8dac0bcfac0307356085f
    gae-java-bot committed Oct 17, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    dfee1ba View commit details

Commits on Oct 18, 2022

  1. Fix GAE LogQuery API javadoc.

    PiperOrigin-RevId: 481932274
    Change-Id: I908350a6922fa8be57e67ab74b82d88e7ba67ae0
    gae-java-bot committed Oct 18, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a5194c5 View commit details

Commits on Oct 19, 2022

  1. Lazily initialize threadStop0

    PiperOrigin-RevId: 482086135
    Change-Id: I7c90d32beac68fbba4323d20a899c0fcad4cc89a
    cushon authored and gae-java-bot committed Oct 19, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9ae1eff View commit details
  2. Remove obsolete (default is now to use jars from Maven builds) use.ma…

    …venjars flag.
    
    PiperOrigin-RevId: 482248400
    Change-Id: Idc314e732e945bd50a02286f125e3944e6ed3dfd
    ludoch authored and gae-java-bot committed Oct 19, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    60acdc1 View commit details

Commits on Oct 20, 2022

  1. Add JDK19 as a build/test env for the GAE runtime.

    PiperOrigin-RevId: 482498764
    Change-Id: I9accbdd9e5be050760940d14ba1144f633c03f46
    ludoch authored and gae-java-bot committed Oct 20, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    705494b View commit details
  2. Allows new JDK19 compilation/testing for GAE runtime

    PiperOrigin-RevId: 482535573
    Change-Id: I47caa30259a9058004f6e3d738436fc35f68ea68
    ludoch authored and gae-java-bot committed Oct 20, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c2ddf02 View commit details
  3. Optimize how we consume Maven built jars inside google code repositor…

    …y for production usage.
    
    PiperOrigin-RevId: 482586475
    Change-Id: I0d29a3d32f903591260ed0f1512b57267c38655d
    ludoch authored and gae-java-bot committed Oct 20, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f0aa396 View commit details

Commits on Oct 22, 2022

  1. Bump external dependencies.

    PiperOrigin-RevId: 482922972
    Change-Id: I97ee958c8a942713c0df6e53ee80c0da66081c2d
    ludoch authored and gae-java-bot committed Oct 22, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    bd1ec98 View commit details

Commits on Oct 24, 2022

  1. Minor tweaks to JettyServletEngineAdapter and JettyHttpProxy for reus…

    …ability
    
    PiperOrigin-RevId: 483470487
    Change-Id: I21e9159b0ef950651f774f026a9a9ca6af0dad1c
    gae-java-bot committed Oct 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c4f2067 View commit details

Commits on Oct 26, 2022

  1. Minor tweaks to JettyServletEngineAdapter and JettyHttpProxy for reus…

    …ability
    
    PiperOrigin-RevId: 484097749
    Change-Id: Ia6d01dcb0e048304b36e23f15255d66d7f285273
    gae-java-bot committed Oct 26, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3cdbcf9 View commit details

Commits on Oct 27, 2022

  1. Minor tweaks to JettyServletEngineAdapter and JettyHttpProxy for reus…

    …ability
    
    PiperOrigin-RevId: 484251696
    Change-Id: Ic1c5177be7a0ade96f93a8fc9e8db73e26e3ac51
    gae-java-bot committed Oct 27, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    db5279f View commit details

Commits on Oct 31, 2022

  1. Minor tweaks to JettyServletEngineAdapter and JettyHttpProxy for reus…

    …ability
    
    PiperOrigin-RevId: 485072718
    Change-Id: I32a9c7490b5953ed75230d4437e033eb39dcf15e
    gae-java-bot committed Oct 31, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    dfb2a3b View commit details

Commits on Nov 1, 2022

  1. Bump Maven dependencies.

    PiperOrigin-RevId: 485392781
    Change-Id: Ie6b9fde4c73845ce942df988c66a95b0877638e9
    ludoch authored and gae-java-bot committed Nov 1, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    6a2b1db View commit details

Commits on Nov 2, 2022

  1. Exposes access token based auth in Remote API & Cloud-Datastore configs.

    PiperOrigin-RevId: 485593295
    Change-Id: If725e956d90b498da314e4253396dcd60eea5d78
    gae-java-bot committed Nov 2, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    95a5e5d View commit details

Commits on Nov 3, 2022

  1. Minor tweaks to JettyServletEngineAdapter and JettyHttpProxy for reus…

    …ability
    
    PiperOrigin-RevId: 485756933
    Change-Id: Ibe3762c215d0b9a99de8259d8946dfd0386e7603
    gae-java-bot committed Nov 3, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    772d298 View commit details
  2. Internal change

    PiperOrigin-RevId: 485951949
    Change-Id: I4c1f142df64fbf346689158a4274d67bcf147a16
    Sriram Mahavadi authored and gae-java-bot committed Nov 3, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a8b5377 View commit details

Commits on Nov 4, 2022

  1. Internal change

    PiperOrigin-RevId: 486235380
    Change-Id: I20df925cac63afb8fadf9d14b7dd713cf905cb6d
    Sriram Mahavadi authored and gae-java-bot committed Nov 4, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    21ec1a7 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    36e1c4e View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4a5aae0 View commit details
Showing with 1,111 additions and 504 deletions.
  1. +1 −1 .github/workflows/maven.yml
  2. +1 −1 api/pom.xml
  3. +15 −5 api/src/main/java/com/google/appengine/api/datastore/CloudDatastoreRemoteServiceConfig.java
  4. +17 −3 api/src/main/java/com/google/appengine/api/datastore/CloudDatastoreV1ClientImpl.java
  5. +10 −1 api/src/main/java/com/google/appengine/api/datastore/DatastoreServiceGlobalConfig.java
  6. +5 −5 api/src/main/java/com/google/appengine/api/log/LogQuery.java
  7. +1 −1 api_dev/pom.xml
  8. +8 −6 api_dev/src/test/java/com/google/appengine/api/images/dev/LocalImagesServiceTest.java
  9. +1 −1 api_legacy/pom.xml
  10. +1 −1 appengine-api-1.0-sdk/pom.xml
  11. +1 −1 appengine-api-stubs/pom.xml
  12. +1 −1 appengine_jsr107/pom.xml
  13. +1 −1 appengine_resources/pom.xml
  14. +1 −1 appengine_testing/pom.xml
  15. +1 −1 appengine_testing_tests/pom.xml
  16. +1 −1 applications/pom.xml
  17. +3 −4 applications/proberapp/pom.xml
  18. +2 −3 applications/springboot/pom.xml
  19. +27 −19 kokoro/gcp_ubuntu/build.sh
  20. +1 −1 lib/pom.xml
  21. +1 −1 lib/tools_api/pom.xml
  22. +1 −1 lib/xml_validator/pom.xml
  23. +1 −1 lib/xml_validator_test/pom.xml
  24. +1 −1 local_runtime_shared/pom.xml
  25. +11 −11 pom.xml
  26. +1 −1 protobuf/pom.xml
  27. +1 −1 quickstartgenerator/pom.xml
  28. +1 −1 remoteapi/pom.xml
  29. +25 −4 remoteapi/src/main/java/com/google/appengine/tools/remoteapi/RemoteApiOptions.java
  30. +2 −4 runtime/annotationscanningwebapp/pom.xml
  31. +1 −1 runtime/deployment/pom.xml
  32. +2 −4 runtime/failinitfilterwebapp/pom.xml
  33. +1 −1 runtime/impl/pom.xml
  34. +10 −9 runtime/impl/src/main/java/com/google/apphosting/runtime/RequestManager.java
  35. +11 −2 runtime/impl/src/main/java/com/google/apphosting/runtime/jetty94/AppVersionHandlerFactory.java
  36. +10 −381 runtime/impl/src/main/java/com/google/apphosting/runtime/jetty94/JettyHttpProxy.java
  37. +1 −1 ...e/impl/src/main/java/com/google/apphosting/runtime/jetty94/JettyServerConnectorWithReusePort.java
  38. +2 −1 runtime/impl/src/main/java/com/google/apphosting/runtime/jetty94/JettyServletEngineAdapter.java
  39. +426 −0 runtime/impl/src/main/java/com/google/apphosting/runtime/jetty94/UPRequestTranslator.java
  40. +481 −0 runtime/impl/src/test/java/com/google/apphosting/runtime/jetty94/UPRequestTranslatorTest.java
  41. +1 −1 runtime/local/pom.xml
  42. +1 −1 runtime/main/pom.xml
  43. +5 −1 runtime/main/src/main/java/com/google/apphosting/runtime/JavaRuntimeMain.java
  44. +2 −4 runtime/nogaeapiswebapp/pom.xml
  45. +1 −1 runtime/pom.xml
  46. +1 −1 runtime/test/pom.xml
  47. +1 −1 runtime/testapps/pom.xml
  48. +1 −1 runtime/util/pom.xml
  49. +1 −1 runtime_shared/pom.xml
  50. +3 −3 sdk_assembly/pom.xml
  51. +1 −1 sessiondata/pom.xml
  52. +1 −1 shared_sdk/pom.xml
  53. +2 −2 third_party/geronimo_javamail/pom.xml
  54. +1 −1 utils/pom.xml
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
java: [8, 11, 17]
java: [8, 11, 17, 19]
jdk: [temurin]
fail-fast: false

2 changes: 1 addition & 1 deletion api/pom.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<properties>
<maven.deploy.skip>true</maven.deploy.skip>
Original file line number Diff line number Diff line change
@@ -106,6 +106,7 @@ private DatastoreServiceGlobalConfig toInternalConfig() {
.hostOverride(hostOverride())
.additionalAppIds(additionalAppIdsAsStrings())
.serviceAccount(serviceAccount())
.accessToken(accessToken())
.privateKey(privateKey())
.useComputeEngineCredential(useComputeEngineCredential())
.installApiProxyEnvironment(installApiProxyEnvironment())
@@ -179,6 +180,8 @@ String appIdString() {

abstract @Nullable PrivateKey privateKey();

abstract @Nullable String accessToken();

abstract boolean useComputeEngineCredential();

abstract int maxRetries();
@@ -187,8 +190,7 @@ String appIdString() {

abstract boolean asyncStackTraceCaptureEnabled();

@Nullable
ImmutableSet<String> additionalAppIdsAsStrings() {
@Nullable ImmutableSet<String> additionalAppIdsAsStrings() {
if (additionalAppIds() == null) {
return null;
}
@@ -253,8 +255,8 @@ public abstract CloudDatastoreRemoteServiceConfig.Builder installApiProxyEnviron
* If set to true, always use a Compute Engine credential instead of using the Application
* Default Credentials library to construct the credential.
*
* <p>Cannot be combined with a call to {@link #useServiceAccountCredential(String,
* PrivateKey)}.
* <p>Cannot be combined with a call to {@link #useServiceAccountCredential(String, PrivateKey)}
* or {@link #accessToken(String)}.
*/
public abstract CloudDatastoreRemoteServiceConfig.Builder useComputeEngineCredential(
boolean value);
@@ -273,11 +275,19 @@ public abstract CloudDatastoreRemoteServiceConfig.Builder useComputeEngineCreden
public abstract CloudDatastoreRemoteServiceConfig.Builder asyncStackTraceCaptureEnabled(
boolean value);

/**
* Sets the access token.
*
* <p>Cannot be combined with a call to {@link #useComputeEngineCredential(boolean)} or {@link
* #useServiceAccountCredential(String, PrivateKey)}.
*/
public abstract CloudDatastoreRemoteServiceConfig.Builder accessToken(String accessToken);
/**
* Instructs the client to use a service account credential instead of using the Application
* Default Credentials library to construct the credential.
*
* <p>Cannot be combined with a call to {@link #useComputeEngineCredential(boolean)}.
* <p>Cannot be combined with a call to {@link #useComputeEngineCredential(boolean)} or {@link
* #accessToken(String)}.
*/
public CloudDatastoreRemoteServiceConfig.Builder useServiceAccountCredential(
String serviceAccountId, PrivateKey privateKey) {
Original file line number Diff line number Diff line change
@@ -323,6 +323,15 @@ private static Credential getCredential() throws GeneralSecurityException, IOExc
return new ComputeCredential(
GoogleNetHttpTransport.newTrustedTransport(), GsonFactory.getDefaultInstance());
}
if (DatastoreServiceGlobalConfig.getConfig().accessToken() != null) {
GoogleCredential credential =
getCredentialBuilder()
.build()
.setAccessToken(DatastoreServiceGlobalConfig.getConfig().accessToken())
.createScoped(DatastoreOptions.SCOPES);
credential.refreshToken();
return credential;
}
return GoogleCredential.getApplicationDefault().createScoped(DatastoreOptions.SCOPES);
}

@@ -347,10 +356,15 @@ private static void setProjectEndpoint(String projectId, DatastoreOptions.Builde

private static GoogleCredential.Builder getServiceAccountCredentialBuilder(String account)
throws GeneralSecurityException, IOException {
return new GoogleCredential.Builder()
.setTransport(GoogleNetHttpTransport.newTrustedTransport())
.setJsonFactory(GsonFactory.getDefaultInstance())
return getCredentialBuilder()
.setServiceAccountId(account)
.setServiceAccountScopes(DatastoreOptions.SCOPES);
}

private static GoogleCredential.Builder getCredentialBuilder()
throws GeneralSecurityException, IOException {
return new GoogleCredential.Builder()
.setTransport(GoogleNetHttpTransport.newTrustedTransport())
.setJsonFactory(GsonFactory.getDefaultInstance());
}
}
Original file line number Diff line number Diff line change
@@ -201,6 +201,9 @@ static Environment getCurrentApiProxyEnvironment() {
@Nullable
abstract String emulatorHost();

@Nullable
abstract String accessToken();

@Nullable
abstract String serviceAccount();

@@ -258,6 +261,8 @@ abstract static class Builder {

abstract DatastoreServiceGlobalConfig.Builder useApiProxy(boolean value);

abstract DatastoreServiceGlobalConfig.Builder accessToken(String value);

abstract DatastoreServiceGlobalConfig.Builder serviceAccount(String value);

abstract DatastoreServiceGlobalConfig.Builder privateKey(PrivateKey value);
@@ -301,7 +306,8 @@ DatastoreServiceGlobalConfig build() {
checkState(
config.additionalAppIds() == null,
"Cannot specify additional app IDs when using API proxy.");

checkState(
config.accessToken() == null, "Cannot specify access token when using API proxy.");
checkState(
config.serviceAccount() == null,
"Cannot specify service account when using API proxy.");
@@ -346,6 +352,9 @@ DatastoreServiceGlobalConfig build() {
!(config.serviceAccount() != null && config.useComputeEngineCredential()),
"Must not provide a service account and at the same time require the use of Compute "
+ "Engine credentials.");
checkState(
config.accessToken() == null || config.serviceAccount() == null,
"Must not provide both an access token and a service account.");

return config;
}
10 changes: 5 additions & 5 deletions api/src/main/java/com/google/appengine/api/log/LogQuery.java
Original file line number Diff line number Diff line change
@@ -293,11 +293,11 @@ public static LogQuery withStartTimeUsec(long startTimeUsec) {
}

/**
* Create a {@link LogQuery} with the given end time.
* Shorthand for <code>LogQuery.Builder.withDefaults().endTimeMillis(endTimeMillis);</code>.
* Please read the {@link LogQuery} class javadoc for an explanation of
* how end time is used.
* @param endTimeMillis the start time to use, in milliseconds.
* Create a {@link LogQuery} with the given end time. Shorthand for <code>
* LogQuery.Builder.withDefaults().endTimeMillis(endTimeMillis);</code>. Please read the {@link
* LogQuery} class javadoc for an explanation of how end time is used.
*
* @param endTimeMillis the end time to use, in milliseconds.
* @return The newly created LogQuery instance.
*/
public static LogQuery withEndTimeMillis(long endTimeMillis) {
2 changes: 1 addition & 1 deletion api_dev/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
Original file line number Diff line number Diff line change
@@ -487,12 +487,14 @@ private void compareImage(String filename, byte[] responseImage) throws IOExcept
assertThat(responseImage).isEqualTo(expectedImage);
}

private static boolean isJdk11or17() {
return StandardSystemProperty.JAVA_SPECIFICATION_VERSION.value().equals("11")
|| StandardSystemProperty.JAVA_SPECIFICATION_VERSION.value().equals("17");
private static boolean isJDK8() {
return StandardSystemProperty.JAVA_SPECIFICATION_VERSION.value().equals("1.8");
}

private static final String jdk11or17Name(String filename) {
/**
* We have 2 test files per image: one for jdk8 and the other one (11) used by jdk 11,17 and above
*/
private static final String jdk11(String filename) {
return filename.replaceAll("(?!-jdk11)\\.(png|jpg)$", "-jdk11.$1");
}

@@ -504,8 +506,8 @@ private static final String jdk11or17Name(String filename) {
*/
private byte[] readImage(String filename) throws IOException {
URL resource = null;
if (isJdk11or17()) {
String jdk11Name = jdk11or17Name(filename);
if (!isJDK8()) {
String jdk11Name = jdk11(filename);
resource = getClass().getResource("testdata/" + jdk11Name);
}
if (resource == null) {
2 changes: 1 addition & 1 deletion api_legacy/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion appengine-api-1.0-sdk/pom.xml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: appengine-api-1.0-sdk</name>
2 changes: 1 addition & 1 deletion appengine-api-stubs/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion appengine_jsr107/pom.xml
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<dependencies>
2 changes: 1 addition & 1 deletion appengine_resources/pom.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: appengine-resources</name>
2 changes: 1 addition & 1 deletion appengine_testing/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion appengine_testing_tests/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion applications/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>pom</packaging>
<properties>
7 changes: 3 additions & 4 deletions applications/proberapp/pom.xml
Original file line number Diff line number Diff line change
@@ -14,9 +14,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>
<packaging>war</packaging>
@@ -27,7 +25,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>applications</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<properties>
@@ -41,6 +39,7 @@

<appengine.target.version>${project.version}</appengine.target.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<appengine.runtime.location>target/${project.artifactId}-${project.version}</appengine.runtime.location>
</properties>

<dependencies>
5 changes: 2 additions & 3 deletions applications/springboot/pom.xml
Original file line number Diff line number Diff line change
@@ -15,13 +15,12 @@
limitations under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.google.appengine.demos</groupId>
<artifactId>springboot</artifactId>
<version>0.0.1-SNAPSHOT</version>
<version>0.0.2-SNAPSHOT</version>
<packaging>war</packaging>

<name>AppEngine :: springboot</name>
46 changes: 27 additions & 19 deletions kokoro/gcp_ubuntu/build.sh
Original file line number Diff line number Diff line change
@@ -27,31 +27,39 @@ echo "JAVA_HOME = $JAVA_HOME"

./mvnw -e clean install

# The artifacts under `${KOKORO_ARTIFACTS_DIR}/maven-artifacts` will be uploaded.
mkdir ${KOKORO_ARTIFACTS_DIR}/maven-artifacts
# The artifacts under `${KOKORO_ARTIFACTS_DIR}/maven-artifacts` will be uploaded as a zip file named maven_jars.binary
TMP_STAGING_LOCATION=${KOKORO_ARTIFACTS_DIR}/tmp
PUBLISHED_LOCATION=${KOKORO_ARTIFACTS_DIR}/maven-artifacts
mkdir ${TMP_STAGING_LOCATION}
mkdir ${PUBLISHED_LOCATION}
# Remove jars we do not need in google3.
ls **/*.jar
rm **/target/*sources.jar || true
rm **/target/*tests.jar || true

# LINT.IfChange
cp api_legacy/target/appengine-api-legacy*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-api-legacy.jar
cp appengine-api-1.0-sdk/target/appengine-api-1.0-sdk*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-api-1.0-sdk.jar
cp appengine-api-stubs/target/appengine-api-stubs*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-api-stubs.jar
cp appengine_testing/target/appengine-testing*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-testing.jar
cp remoteapi/target/appengine-remote-api*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-remote-api.jar
cp appengine_jsr107/target/appengine-jsr107*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-jsr107.jar
cp runtime_shared/target/runtime-shared*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/runtime-shared.jar
cp lib/tools_api/target/appengine-tools-sdk*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-tools-api.jar
cp lib/xml_validator/target/libxmlvalidator*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/libxmlvalidator.jar
cp runtime/impl/target/runtime-impl*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/runtime-impl.jar
cp runtime/local/target/appengine-local-runtime*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-local-runtime.jar
cp runtime/main/target/runtime-main*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/runtime-main.jar
cp local_runtime_shared/target/appengine-local-runtime-shared*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-local-runtime-shared.jar
cp quickstartgenerator/target/quickstartgenerator*.jar ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/quickstartgenerator.jar
cp api_legacy/target/appengine-api-legacy*.jar ${TMP_STAGING_LOCATION}/appengine-api-legacy.jar
cp appengine-api-1.0-sdk/target/appengine-api-1.0-sdk*.jar ${TMP_STAGING_LOCATION}/appengine-api-1.0-sdk.jar
cp appengine-api-stubs/target/appengine-api-stubs*.jar ${TMP_STAGING_LOCATION}/appengine-api-stubs.jar
cp appengine_testing/target/appengine-testing*.jar ${TMP_STAGING_LOCATION}/appengine-testing.jar
cp remoteapi/target/appengine-remote-api*.jar ${TMP_STAGING_LOCATION}/appengine-remote-api.jar
cp appengine_jsr107/target/appengine-jsr107*.jar ${TMP_STAGING_LOCATION}/appengine-jsr107.jar
cp runtime_shared/target/runtime-shared*.jar ${TMP_STAGING_LOCATION}/runtime-shared.jar
cp lib/tools_api/target/appengine-tools-sdk*.jar ${TMP_STAGING_LOCATION}/appengine-tools-api.jar
cp lib/xml_validator/target/libxmlvalidator*.jar ${TMP_STAGING_LOCATION}/libxmlvalidator.jar
cp runtime/impl/target/runtime-impl*.jar ${TMP_STAGING_LOCATION}/runtime-impl.jar
cp runtime/local/target/appengine-local-runtime*.jar ${TMP_STAGING_LOCATION}/appengine-local-runtime.jar
cp runtime/main/target/runtime-main*.jar ${TMP_STAGING_LOCATION}/runtime-main.jar
cp local_runtime_shared/target/appengine-local-runtime-shared*.jar ${TMP_STAGING_LOCATION}/appengine-local-runtime-shared.jar
cp quickstartgenerator/target/quickstartgenerator*.jar ${TMP_STAGING_LOCATION}/quickstartgenerator.jar

cp -rf sdk_assembly/target/appengine-java-sdk ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/
cp -rf sdk_assembly/target/appengine-java-sdk ${TMP_STAGING_LOCATION}/
# Make binaries executable.
chmod a+x ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/appengine-java-sdk/bin/*
chmod a+x ${TMP_STAGING_LOCATION}/appengine-java-sdk/bin/*
# LINT.ThenChange(//depot/google3/third_party/java_src/appengine_standard/check_build.sh)
cp sdk_assembly/target/google_appengine_java_delta*.zip ${KOKORO_ARTIFACTS_DIR}/maven-artifacts/google_appengine_java_delta_from_maven.zip
cp sdk_assembly/target/google_appengine_java_delta*.zip ${TMP_STAGING_LOCATION}/google_appengine_java_delta_from_maven.zip
cd ${TMP_STAGING_LOCATION}
zip -r ${PUBLISHED_LOCATION}/maven_jars.binary .
# cleanup staging area
cd ..
rm -rf ${TMP_STAGING_LOCATION}
2 changes: 1 addition & 1 deletion lib/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>pom</packaging>

2 changes: 1 addition & 1 deletion lib/tools_api/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>lib-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion lib/xml_validator/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>lib-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: libxmlvalidator</name>
2 changes: 1 addition & 1 deletion lib/xml_validator_test/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>lib-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: libxmlvalidator_test</name>
2 changes: 1 addition & 1 deletion local_runtime_shared/pom.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: appengine-local-runtime-shared</name>
22 changes: 11 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
<packaging>pom</packaging>
<name>AppEngine :: Parent project</name>
<modules>
@@ -386,7 +386,7 @@
<dependency>
<groupId>com.google.cloud.datastore</groupId>
<artifactId>datastore-v1-proto-client</artifactId>
<version>2.11.1</version>
<version>2.11.5</version>
</dependency>
<dependency>
<groupId>com.google.geometry</groupId>
@@ -449,12 +449,12 @@
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-datastore-v1</artifactId>
<version>0.102.1</version>
<version>0.103.0</version>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-common-protos</artifactId>
<version>2.9.2</version>
<version>2.9.6</version>
</dependency>
<dependency>
<groupId>com.google.code.findbugs</groupId>
@@ -626,22 +626,22 @@
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-api</artifactId>
<version>1.49.0</version>
<version>1.49.2</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
<version>1.49.0</version>
<version>1.49.2</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-protobuf</artifactId>
<version>1.49.0</version>
<version>1.49.2</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-netty</artifactId>
<version>1.49.0</version>
<version>1.49.2</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat</groupId>
@@ -656,12 +656,12 @@
<dependency>
<groupId>joda-time</groupId>
<artifactId>joda-time</artifactId>
<version>2.11.1</version>
<version>2.11.2</version>
</dependency>
<dependency>
<groupId>org.json</groupId>
<artifactId>json</artifactId>
<version>20220320</version>
<version>20220924</version>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
@@ -789,7 +789,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.3.0</version>
<version>3.4.1</version>
</plugin>
<plugin>
<groupId>com.github.os72</groupId>
2 changes: 1 addition & 1 deletion protobuf/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion quickstartgenerator/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion remoteapi/pom.xml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<packaging>jar</packaging>
<name>AppEngine :: appengine-remote-api</name>
Original file line number Diff line number Diff line change
@@ -227,6 +227,24 @@ public RemoteApiOptions useServiceAccountCredential(
return this;
}

/**
* Use an access token credential. Overrides any previously-provided credentials.
*
* @param accessToken the access token (generally from {@link GoogleCredential#getAccessToken})
* @return this {@code RemoteApiOptions} instance
*/
public RemoteApiOptions useAccessToken(String accessToken) {
try {
GoogleCredential credential = getCredentialBuilder().build().setAccessToken(accessToken);
credential = credential.createScoped(OAUTH_SCOPES);
credential.refreshToken();
setOAuthCredential(credential);
} catch (IOException | GeneralSecurityException e) {
throw new RuntimeException("Failed to build access token credential.", e);
}
return this;
}

/**
* Use credentials appropriate for talking to the Development Server. Overrides any
* previously-provided credentials.
@@ -247,13 +265,16 @@ public RemoteApiOptions useDevelopmentServerCredential() {
return this;
}

private GoogleCredential.Builder getCredentialBuilder(String serviceAccountId)
private GoogleCredential.Builder getCredentialBuilder()
throws GeneralSecurityException, IOException {
HttpTransport transport = getOrCreateHttpTransportForOAuth();
JsonFactory jsonFactory = GsonFactory.getDefaultInstance();
return new GoogleCredential.Builder()
.setTransport(transport)
.setJsonFactory(jsonFactory)
return new GoogleCredential.Builder().setTransport(transport).setJsonFactory(jsonFactory);
}

private GoogleCredential.Builder getCredentialBuilder(String serviceAccountId)
throws GeneralSecurityException, IOException {
return getCredentialBuilder()
.setServiceAccountId(serviceAccountId)
.setServiceAccountScopes(OAUTH_SCOPES);
}
6 changes: 2 additions & 4 deletions runtime/annotationscanningwebapp/pom.xml
Original file line number Diff line number Diff line change
@@ -14,13 +14,11 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>
<packaging>war</packaging>
<version>1.0</version>
<version>1.1-SNAPSHOT</version>

<groupId>com.google.appengine.demos</groupId>
<artifactId>annotationscanningwebapp</artifactId>
2 changes: 1 addition & 1 deletion runtime/deployment/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>pom</packaging>
6 changes: 2 additions & 4 deletions runtime/failinitfilterwebapp/pom.xml
Original file line number Diff line number Diff line change
@@ -14,13 +14,11 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>
<packaging>war</packaging>
<version>1.0</version>
<version>1.1-SNAPSHOT</version>

<groupId>com.google.appengine.demos</groupId>
<artifactId>failinitfilterwebapp</artifactId>
2 changes: 1 addition & 1 deletion runtime/impl/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
Original file line number Diff line number Diff line change
@@ -500,14 +500,15 @@ public void sendDeadline(String securityTicket, boolean isUncatchable) {
// So at least for the time being we can still achieve the effect of Thread.stop(Throwable) by
// calling the JNI method. That means we don't get the permission checks and so on that come
// with Thread.stop, but the code that's calling it is privileged anyway.
private static final Method threadStop0;

static {
try {
threadStop0 = Thread.class.getDeclaredMethod("stop0", Object.class);
threadStop0.setAccessible(true);
} catch (NoSuchMethodException e) {
throw new RuntimeException(e);
private static class ThreadStop0Holder {
private static final Method threadStop0;
static {
try {
threadStop0 = Thread.class.getDeclaredMethod("stop0", Object.class);
threadStop0.setAccessible(true);
} catch (NoSuchMethodException e) {
throw new RuntimeException(e);
}
}
}

@@ -611,7 +612,7 @@ public void sendDeadline(RequestToken token, boolean isUncatchable) {
AccessController.doPrivileged(
(PrivilegedAction<Void>) () -> {
try {
threadStop0.invoke(targetThread, throwable);
ThreadStop0Holder.threadStop0.invoke(targetThread, throwable);
} catch (Exception e) {
logger.atWarning().withCause(e).log("Failed to stop thread");
}
Original file line number Diff line number Diff line change
@@ -101,12 +101,17 @@ public class AppVersionHandlerFactory {
private final Server server;
private final String serverInfo;
private final WebAppContextFactory contextFactory;
private final boolean useJettyErrorPageHandler;

public AppVersionHandlerFactory(
Server server, String serverInfo, WebAppContextFactory contextFactory) {
Server server,
String serverInfo,
WebAppContextFactory contextFactory,
boolean useJettyErrorPageHandler) {
this.server = server;
this.serverInfo = serverInfo;
this.contextFactory = contextFactory;
this.useJettyErrorPageHandler = useJettyErrorPageHandler;
}

/**
@@ -146,7 +151,11 @@ private Handler doCreateHandler(AppVersion appVersion) throws ServletException {
context.setServer(server);
context.setDefaultsDescriptor(WEB_DEFAULTS_XML);
context.setClassLoader(appVersion.getClassLoader());
context.setErrorHandler(new NullErrorHandler());
if (useJettyErrorPageHandler) {
context.getErrorHandler().setShowStacks(false);
} else {
context.setErrorHandler(new NullErrorHandler());
}
File qswebxml = new File(contextRoot, "WEB-INF/quickstart-web.xml");
if (qswebxml.exists()) {
context.setConfigurationClasses(quickstartConfigurationClasses);

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
* A wrapper for Jetty to add support for SO_REUSEPORT. (Jetty 9.x does not directly expose it as a
* setting.) SO_REUSEPORT only works when running with a Java 9+ JDK.
*/
class JettyServerConnectorWithReusePort extends ServerConnector {
public class JettyServerConnectorWithReusePort extends ServerConnector {

private final boolean reusePort;

Original file line number Diff line number Diff line change
@@ -97,7 +97,8 @@ public void start(String serverInfo, ServletEngineAdapter.Config runtimeOptions)
rpcConnector = new RpcConnector(server);
server.setConnectors(new Connector[] {rpcConnector});
AppVersionHandlerFactory appVersionHandlerFactory =
new AppVersionHandlerFactory(server, serverInfo, contextFactory);
new AppVersionHandlerFactory(
server, serverInfo, contextFactory, /*useJettyErrorPageHandler=*/ false);
appVersionHandlerMap = new AppVersionHandlerMap(appVersionHandlerFactory);
server.setHandler(appVersionHandlerMap);

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion runtime/local/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion runtime/main/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
Original file line number Diff line number Diff line change
@@ -40,7 +40,11 @@ public class JavaRuntimeMain {
private static final Logger logger = Logger.getLogger(JavaRuntimeMain.class.getName());
private static final String PROPERTIES_LOCATION = "WEB-INF/appengine_optional.properties";

/** This property will be used in ClassPathUtils processing to determine the correct classpath. */
/**
* This property will be used in ClassPathUtils processing to determine the correct classpath.
* Property must now be true for the Java8 runtime, and is ignored for Java11/17 runtimes which
* can only use maven jars.
*/
private static final String USE_MAVEN_JARS = "use.mavenjars";

/**
6 changes: 2 additions & 4 deletions runtime/nogaeapiswebapp/pom.xml
Original file line number Diff line number Diff line change
@@ -14,13 +14,11 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

<modelVersion>4.0.0</modelVersion>
<packaging>war</packaging>
<version>1.0</version>
<version>1.1-SNAPSHOT</version>

<groupId>com.google.appengine.demos</groupId>
<artifactId>nogaeapiswebapp</artifactId>
2 changes: 1 addition & 1 deletion runtime/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<name>AppEngine :: runtime projects</name>
<packaging>pom</packaging>
2 changes: 1 addition & 1 deletion runtime/test/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion runtime/testapps/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion runtime/util/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>runtime-parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion runtime_shared/pom.xml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
6 changes: 3 additions & 3 deletions sdk_assembly/pom.xml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<artifactId>appengine-java-sdk</artifactId>
@@ -278,8 +278,8 @@
<chmod dir="${assembly-directory}/bin" perm="755" includes="**/*.sh" />
</target>
<tasks>
<delete file="${assembly-directory}/jetty94/jetty-home/lib/apache-jsp/org.eclipse.jetty.apache-jsp-${jetty.version}.jar"/>
<delete dir="${assembly-directory}/jetty94/jetty-home/demo-base"/>
<delete file="${assembly-directory}/jetty94/jetty-home/lib/apache-jsp/org.eclipse.jetty.apache-jsp-${jetty.version}.jar" />
<delete dir="${assembly-directory}/jetty94/jetty-home/demo-base" />
</tasks>
</configuration>
</execution>
2 changes: 1 addition & 1 deletion sessiondata/pom.xml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
2 changes: 1 addition & 1 deletion shared_sdk/pom.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>

<packaging>jar</packaging>
4 changes: 2 additions & 2 deletions third_party/geronimo_javamail/pom.xml
Original file line number Diff line number Diff line change
@@ -22,14 +22,14 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>geronimo-javamail_1.4_spec</artifactId>
<packaging>jar</packaging>
<name>AppEngine :: JavaMail 1.4</name>
<version>1.4.4-${project.parent.version}</version>
<version>1.4.4-3.0.10-SNAPSHOT</version>

<description>Javamail 1.4 Specification with AppEngine updates.</description>

2 changes: 1 addition & 1 deletion utils/pom.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
<parent>
<groupId>com.google.appengine</groupId>
<artifactId>parent</artifactId>
<version>2.0.10-SNAPSHOT</version>
<version>2.0.11-SNAPSHOT</version>
</parent>
<properties>
<maven.deploy.skip>true</maven.deploy.skip>