Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binaries in the java11 standard buildpath #840

Closed
2 tasks done
loosebazooka opened this issue Jun 13, 2020 · 3 comments
Closed
2 tasks done

Add support for binaries in the java11 standard buildpath #840

loosebazooka opened this issue Jun 13, 2020 · 3 comments

Comments

@loosebazooka
Copy link
Contributor

loosebazooka commented Jun 13, 2020

Currently, artifacts are presumed to be jars and processed according (inspected). This feature request is to allow non-jar artifacts as long as the user has defined a custom entrypoint in the app.yaml.

@loosebazooka
Copy link
Contributor Author

loosebazooka commented Jun 13, 2020

@ludoch FYI

@loosebazooka
Copy link
Contributor Author

Testing instructions

  1. clone repo
  2. ./mvnw clean install
  3. modify pom config for app-maven-plugin in test app
<plugin>
    <groupId>com.google.cloud.tools</groupId>
    <artifactId>appengine-maven-plugin</artifactId>
    <version>2.2.0</version>
    <dependencies>
        <dependency>
            <groupId>com.google.cloud.tools</groupId>
            <artifactId>appengine-plugins-core</artifactId>
            <version>0.8.3-SNAPSHOT</version>
        </dependency>
    </dependencies>
</plugin>

@ludoch
Copy link
Collaborator

ludoch commented Jun 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants