Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14 migration #136

Open
cosmo0920 opened this issue Jul 7, 2017 · 15 comments
Open

v0.14 migration #136

cosmo0920 opened this issue Jul 7, 2017 · 15 comments
Assignees

Comments

@cosmo0920
Copy link
Contributor

Why not migrate to Fluentd v0.14 API?

And 100+ plugins have already been migrated to Fluentd v0.14 plugin API.

If you have questions, feel free to mention to me.

@igorpeshansky
Copy link
Member

We are waiting for fluent/fluentd#1555 to be fixed before we fully commit to 0.14.

@cosmo0920
Copy link
Contributor Author

fluent/fluentd#1623 should fix fluent/fluentd#1555.
Is it enough to start v0.14 migration?

@igorpeshansky
Copy link
Member

We just updated our packaging to pull in v0.14.19. We'd like to release that and observe it in the wild for a couple of weeks — if all goes fine, we should be ready to migrate. Ideally, 0.14 would be marked "stable" on the fluentd side first...

@cosmo0920
Copy link
Contributor Author

Fluentd v0.14.22 which is marked as stable release has been released.
https://www.fluentd.org/blog/fluentd-v0.14.22-has-been-released

Is this really enough for v0.14 migration?

@igorpeshansky
Copy link
Member

Some of our clients are still on v0.12. We're working to address the issues they're having with v0.14. Once we have no more clients using the latest fluent-plugin-google-cloud with v0.12, we'll consider migrating to v0.14.

@derekperkins
Copy link

Will this work with 1.x?

@shusugmt
Copy link

This seems to be already done in 906df5e
I confirmed with fluent-plugin-google-cloud 0.7.0 on fluentd 1.2.5

@cosmo0920
Copy link
Contributor Author

@shusugmt No, this plugin still doesn't use Fluentd v1 native API.

@qingling128
Copy link
Contributor

The changes recommended in https://docs.fluentd.org/v1.0/articles/plugin-update-from-v0.12#buffered-output-plugins will need to wait till our next major release to avoid disruptions on the client side. Probably some time next year.

@apu1111
Copy link

apu1111 commented Jun 11, 2019

@qingling128 @igorpeshansky
Any update/timeline for this? I am particularly interested for the multi-worker support.

@qingling128
Copy link
Contributor

@apu1111 - Thanks for checking! The fluent-plugin-google-cloud output plugin itself already supports multi-worker:

As to the next major release cut, it is being evaluated / prioritized in the roadmap now. We are not sure how soon it would be yet though.

@apu1111
Copy link

apu1111 commented Jun 12, 2019

@qingling128 - Thanks for the info. We wanted to upgrade to fluentd 1.4 to use <worker N-M> directive. Anyway will wait for the next major release.

@jkohen
Copy link
Contributor

jkohen commented Jul 30, 2019

@qingling128 can you please triage? What value does this provide?

@qingling128
Copy link
Contributor

@jkohen The values of this migration is described here: https://gist.github.com/okkez/05ee6af7b8bb7de852a36eb2f679c344.

We have to cut a major release for this though, which we already agreed to do. It's a matter of prioritization.

@jkohen
Copy link
Contributor

jkohen commented Jul 30, 2019

Are any of the "pros" listed there and the migration itself particularly valuable for Stackdriver users in order to justify doing the migration sooner? It sounds like no, so just confirming. If that's the case, then I think that we should close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants