Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in naming of special field for trace sampling decision #307

Open
sebright opened this issue Apr 30, 2019 · 5 comments
Open

Inconsistency in naming of special field for trace sampling decision #307

sebright opened this issue Apr 30, 2019 · 5 comments
Assignees
@qingling128
Labels
cleanup

Comments

@sebright
Copy link

I noticed that the special field for the trace sampling decision uses underscores (logging.googleapis.com/trace_sampled), but other special fields use camel case (e.g., logging.googleapis.com/spanId, logging.googleapis.com/sourceLocation). I don't know if this inconsistency is an issue, though.
sebright added a commit to sebright/opencensus-experiments that referenced this issue Apr 30, 2019
@sebright
Update name of trace sampled field recognized by Stackdriver Logging …
29afc70 
…agent.

The field uses underscores instead of camel case.  See
GoogleCloudPlatform/fluent-plugin-google-cloud#307.
@sebright sebright mentioned this issue Apr 30, 2019
Merged
@qingling128
Copy link
Contributor

Hmm... That is not intended. Thanks for the heads up! We'll fix it in the next major release (since it would introduce some backward incompatible change).

@igorpeshansky
Copy link
Member

Could we not support both and deprecate the one with the underscore?

@qingling128
Copy link
Contributor

@igorpeshansky - Like supporting both but having logging.googleapis.com/traceSampled taking precedence of logging.googleapis.com/trace_sampled? That sounds reasonable to me, too.

sebright added a commit to census-ecosystem/opencensus-experiments that referenced this issue May 1, 2019
@sebright
Update name of trace sampled field recognized by Stackdriver Logging …
780a522 
…agent. (#181)

The field uses underscores instead of camel case.  See
GoogleCloudPlatform/fluent-plugin-google-cloud#307.
@jkohen jkohen added the cleanup label Jul 31, 2019
@jkohen
Copy link
Contributor

jkohen commented Jul 31, 2019

@qingling128 I'm assuming the work left is to is just a cleanup. Let's make sure it gets tracked if it's necessary.

@qingling128
Copy link
Contributor

Yes, this is already tracked in the major release cut change list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qingling128 qingling128

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@qingling128 @jkohen @igorpeshansky @sebright