Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Configuring "X-Powered-By" of underlying shelf server #388

Open
zacharypuulsedev opened this issue Apr 29, 2023 · 1 comment
Open
Labels
kind/enhancement New feature or request

Comments

@zacharypuulsedev
Copy link

Per OWASP recommendations, I'd like to remove the "X-Powered-By" header.

Unless there is another option to remove a header with a Cloud Run instance behind a GCP API Gateway, the following is what I'd envision:

According to the shelf documentation, this is doable by passing null for the header:

Future<HttpServer> serve(
Handler handler,
Object address,
int port,
{SecurityContext? securityContext,
int? backlog,
bool shared = false,
String? poweredByHeader = 'Dart with package:shelf'}
)

In serve.dart there is a call to run.

Within run, shelf_io.serve is called, which could be parameterized to pass null to the poweredByHeader param.

https://github.com/GoogleCloudPlatform/functions-framework-dart/blob/main/functions_framework/lib/serve.dart

@kevmoo kevmoo added the kind/enhancement New feature or request label Apr 29, 2023
@kevmoo
Copy link
Collaborator

kevmoo commented Apr 29, 2023

PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants