Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals: Reuse http.Client #1026

Open
3 tasks done
justinsb opened this issue Nov 22, 2023 · 0 comments
Open
3 tasks done

Internals: Reuse http.Client #1026

justinsb opened this issue Nov 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@justinsb
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

@aojea pointed out that we should be reusing the http.Client , to pick up the fixes in kubernetes-sigs/controller-runtime#2122 and kubernetes/kubernetes#105490 .

It's not 100% clear (to me) whether we're using a custom transport, but either way it's more efficient - just in some cases it's much more efficient!

Likely will require a controller-runtime update, as I think we're on an older version.

Additional information

No response

Importance

No response

@justinsb justinsb added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant