Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate fixture names and strengthen test cases #615

Open
damemi opened this issue Mar 17, 2023 · 1 comment
Open

Automatically generate fixture names and strengthen test cases #615

damemi opened this issue Mar 17, 2023 · 1 comment
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request priority: p2

Comments

@damemi
Copy link
Member

damemi commented Mar 17, 2023

Discussed in #613, it would be good if our output fixture names were automatically generated based on the test name. This would help prevent duplicate fixture overwriting, but it would also more clearly identify the test cases each fixture is meant to represent.

One benefit we have right now though is that fixtures are pretty tightly organized, eg:

  • input_fixture.json
  • input_fixture_expected.json
  • input_fixture_alternate_expected.json

Especially in the third case, where 2 tests use the same input fixture (which is fine), having the outputs all colocated with the input is convenient. We probably won't be able to generate the input fixture name based on the test name (especially because multiple tests can use the same input), so we'll have to put some thought into what this actually looks like.

@aabmass aabmass added enhancement New feature or request priority: p2 enhancement accepted An actionable enhancement for which PRs will be accepted labels Mar 27, 2023
@aabmass
Copy link
Contributor

aabmass commented Apr 10, 2023

Triaged, this would be nice but not high priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement accepted An actionable enhancement for which PRs will be accepted enhancement New feature or request priority: p2
Projects
None yet
Development

No branches or pull requests

2 participants