Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify cumulative tests/fixtures are being normalized as expected #671

Open
damemi opened this issue Jul 14, 2023 · 1 comment
Open

Verify cumulative tests/fixtures are being normalized as expected #671

damemi opened this issue Jul 14, 2023 · 1 comment
Labels
enhancement New feature or request priority: p3

Comments

@damemi
Copy link
Member

damemi commented Jul 14, 2023

Noticed in #668 that cumulative normalization should drop the first data point it sees without a start timestamp. We should go through our other sum/cumulative fixtures and make sure the matching expect fixtures accurately represent a cumulative metric. If not, we should disable normalization or add additional points to get matching cumulatives in the output (except we are trying to test normalization dropping points)

@damemi
Copy link
Member Author

damemi commented Jul 17, 2023

One problem is that our test framework currently does one PushMetrics call, so I don't think we can test multiple CreateTimeSeriesRequests against the GCM api.

This means we basically can't test cumulative normalization this way, because if you try to create 2 data points in the same TimeSeriesRequest you will get a duplicate time series error.

The test framework could be updated to make multiple time series requests, which would be a cool enhancement.

@damemi damemi added the enhancement New feature or request label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p3
Projects
None yet
Development

No branches or pull requests

2 participants