Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate collector exporter self-observability from OpenCensus to OpenTelemetry #797

Open
dashpole opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement New feature or request priority: p2

Comments

@dashpole
Copy link
Contributor

Using OpenTelemetry for self-observability metrics is now stable in the collector: open-telemetry/opentelemetry-collector#9102. OpenCensus metrics are still supported on the prometheus endpoint: https://github.com/open-telemetry/opentelemetry-collector/blob/7ade1016cf138965685e533f60ec83892d26abc6/service/internal/proctelemetry/config.go#L212, but the OpenCensus bridge is not used if you are exporting with OTLP, which we might want to support in the future.

Our OpenCensus usage:

We define googlecloudmonitoring/point_count and googlecloudmonitoring/exemplar_attachments_dropped in exporter/collector/observability.go using OpenCensus. Migrating this to OpenTelemetry should be straightforward.

We also use ocgrpc in the collector exporter:

grpc.WithStatsHandler(&ocgrpc.ClientHandler{}),
. Migrating this to OTel may be tricky, as we would need to either migrate to otelgrpc, or to gRPC's upcoming self-observability metrics: https://github.com/grpc/proposal/blob/master/A66-otel-stats.md. This is likely to be a breaking change, which we will need to migrate with a featuregate.

@dashpole dashpole added enhancement New feature or request priority: p2 labels Jan 23, 2024
@dashpole
Copy link
Contributor Author

cc @braydonk @quentinmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p2
Projects
None yet
Development

No branches or pull requests

1 participant