New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMP exporter should convert Int values to Double #798
Comments
This is tricky. If we do this in the exporter, existing users will encounter errors when they upgrade, since their existing metric descriptors are the wrong type. We would likely need to make this opt-in behavior. |
If GMP only supports doubles, how could their descriptors have the wrong type on upgrade? |
I think I must have been mistaken. There was a user that was able to write int metrics, and had problems switching to double. |
Confirmed that GMP accepts both int and double metrics |
In that case, we should probably not change the value type. If users have the same metric in both INT and Double, they can use the above workaround to merge them together. |
Actually, we should document this behavior on the exporter |
GMP only accepts Double values. Sending it an int will cause the metric to be rejected.This is not correct. GMP accepts int and double values.
This can be done with the transform processor today, although I think this needs to be filtered so it only applies to int valued datapoints:
Ideally, the exporter should handle this, rather than requiring users to add processors. I encountered this when using the spanmetrics exporter, which produces int-valued metrics.
The text was updated successfully, but these errors were encountered: