Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Exponential Histogram to Managed Prometheus doesn't work due to unimplemented naming convertion #841

Open
alexvanboxel opened this issue Apr 26, 2024 · 3 comments
Labels
enhancement New feature or request priority: p2

Comments

@alexvanboxel
Copy link

The Google Managed Prometheus naming doesn't support the pmetric.MetricTypeExponentialHistogram; this makes the export of Exponential Histograms fail.

I think adding the following will fix the issue. But I don't know what the correct Suffix would be.

	case pmetric.MetricTypeExponentialHistogram:
		return compliantName + "/???", nil
@dashpole dashpole added the enhancement New feature or request label Apr 26, 2024
@dashpole
Copy link
Contributor

Thanks @alexvanboxel. We are aware of this, and are coordinating with the Google Managed Prometheus team on adding support for exponential histograms.

@alexvanboxel
Copy link
Author

I got it working locally; I've added the above code with /distribution and it works... at least for so far as I see (I can see something in Metrics Explorer. Need more exploration.

@dashpole
Copy link
Contributor

It should work just fine with the regular metrics viewer. I don't believe it will work with promQL yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: p2
Projects
None yet
Development

No branches or pull requests

2 participants