Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit checks to look for secrets and other stuff #546

Open
boredabdel opened this issue Aug 28, 2020 · 3 comments
Open

Add precommit checks to look for secrets and other stuff #546

boredabdel opened this issue Aug 28, 2020 · 3 comments
Assignees

Comments

@boredabdel
Copy link
Member

While reviewing #543 @jaketf had a great suggestion about using precommit-checks https://pre-commit.com/ to look for secrets (like private SA keys) and maybe even enforce license and stuff like that.

I'm not sure how the repo is configure but will have a look at this.

@boredabdel boredabdel self-assigned this Aug 28, 2020
@jaketf
Copy link
Contributor

jaketf commented Jan 21, 2021

@boredabdel I have a decent amount of experience w/ pre-commit.
This example (PSO internal CSR link) might help get you started. I'd be happy to discuss / help if you need. The biggest challenge is the fact that we have so many assets in the exclusion list.

@mik-laj
Copy link
Contributor

mik-laj commented Jan 21, 2021

We have separate repo for pre-commit hooks. https://github.com/google/pre-commit-tool-hooks is it interesting for you?

@jaketf
Copy link
Contributor

jaketf commented Jan 21, 2021

@mik-laj very interesting! thank you for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants