Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring the environments omitted from bundle install #182

Open
DevinFrenze opened this issue Jun 19, 2019 · 1 comment
Open

Comments

@DevinFrenze
Copy link

DevinFrenze commented Jun 19, 2019

because of ruby-generate-dockerfile/app/Dockerfile.erb lines 159 and 161, ruby projects (in my case in the Google App Engine flexible environment) may not deploy using environment names test or development.

although there's a convention to use development locally, I like to use local as the name of my local environment and tried to use development as the name of a deployed environment. however I was stuck with a 502: Bad Gateway status because my dependencies aren't installed when the env is development.

i think this docker file either shouldn't make assumptions about environment names, or should make those assumptions known and allow for some kind of configuration (on App Engine it could be some optional settings in app.yaml)

@dazuma
Copy link
Member

dazuma commented Sep 5, 2019

Because the convention is to use development as the local environment, I think the current default behavior remains correct for most users. But I can see an argument for making it configurable via app.yaml.

@dazuma dazuma changed the title Dockerfile is not environment name agnostic Support configuring the environments omitted from bundle install Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants