docs: publisher executor config properties #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meltsufin
approved these changes
Mar 28, 2024
| | `spring.cloud.gcp.pubsub.publisher.executor-wait-for-tasks-to-complete-on-shutdown` | | ||
| Sets the underlying `ThreadPoolTaskScheduler` 's https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/concurrent/ExecutorConfigurationSupport.html#setWaitForTasksToCompleteOnShutdown(boolean)[waitForTasksToCompleteOnShutdown] property. | ||
| Determines whether to wait for scheduled tasks to complete on shutdown, not interrupting running tasks and executing all tasks in the queue. | ||
| When true, replicates the default behavior before Spring 6.1.x. | No | false |
There was a problem hiding this comment.
I wonder if we should default to true for backwards compatibility.
There was a problem hiding this comment.
I suggest leaving it.
This was introduced as we moved to a new major version, it just happens to be one of the breaking changes we didn't introduce directly but instead indirectly via our Spring version bumps. Customers will not be exposed to this change in behavior w/o choosing to update to a new major.
I think it would also result in an inconsistent message about which Spring behavior changes we chose to override and which we chose to keep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2745