feat: Spring Cloud AlloyDB integration (#2787) #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
feat-alloydb-integration
branch
from
51a5148
to
ff6f801
Compare
ttosta-google
force-pushed
the
feat-alloydb-integration
branch
from
e3a7316
to
abba0f2
Compare
burkedavison
approved these changes
Apr 22, 2024
meltsufin
requested changes
Apr 22, 2024
...main/java/com/google/cloud/spring/autoconfigure/alloydb/AlloyDbEnvironmentPostProcessor.java
Show resolved
Hide resolved
...configure/src/main/java/com/google/cloud/spring/autoconfigure/alloydb/AlloyDbProperties.java
Show resolved
Hide resolved
Comment on lines
+35
to
+38
| NOTE: You need to run the sample from a VM within the created VPC to connect to AlloyDB using its private IP. | ||
| To connect using Public IP, enable the AlloyDB instance's for external connections | ||
| following https://cloud.google.com/alloydb/docs/connect-public-ip[these instructions] and | ||
| add `spring.cloud.gcp.alloydb.ip-type=PUBLIC` to your `application.properties`. |
There was a problem hiding this comment.
Is this covered in the reference documentation as well?
There was a problem hiding this comment.
Added to docs/alloydb.adoc as well.
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "name": "spring-cloud-gcp-starter-alloydb", | |||
There was a problem hiding this comment.
@burkedavison Do we need this? I don't think we provide repo metadata for other modules in this project.
There was a problem hiding this comment.
All of the starters do have them. (https://github.com/GoogleCloudPlatform/spring-cloud-gcp/tree/main/spring-cloud-gcp-starters)
Whether we need them --> I don't know of a use-case of them today.
spring-cloud-gcp-starters/spring-cloud-gcp-starter-alloydb/pom.xml
Outdated
Show resolved
Hide resolved
|
meltsufin
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a component to allow our customers to connect to Google Cloud AlloyDB instances using Spring Boot with the Java Connector integration.
It includes a starter, autoconfigure, sample, associated integrations tests and documentation.
Issue related: GoogleCloudPlatform/alloydb-java-connector#151