Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): guard against "Type must not be Null" #2797

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix(datastore): guard against "Type must not be Null" #2797

merged 3 commits into from
Apr 30, 2024

Conversation

meltsufin
Copy link
Member

Fixes: #2774.

@meltsufin meltsufin marked this pull request as ready for review April 29, 2024 20:04
@meltsufin meltsufin requested a review from a team as a code owner April 29, 2024 20:04
@JoeWang1127
Copy link
Contributor

Do we need to include a unit test?

@meltsufin
Copy link
Member Author

Do we need to include a unit test?

Yes, added!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@meltsufin meltsufin enabled auto-merge (squash) April 29, 2024 21:23
@meltsufin meltsufin merged commit 9a2ee15 into main Apr 30, 2024
52 of 56 checks passed
@meltsufin meltsufin deleted the type-must-not-be-null branch April 30, 2024 15:36
@release-please release-please bot mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Boot+datastore throws "Type must not be Null" when JsonNode is used as attribute on a Datastore Entity
3 participants
@meltsufin @JoeWang1127 @burkedavison