Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to report an Angular HttpErrorResponse #81

Open
beck opened this issue Sep 24, 2020 · 0 comments
Open

Fails to report an Angular HttpErrorResponse #81

beck opened this issue Sep 24, 2020 · 0 comments

Comments

@beck
Copy link

beck commented Sep 24, 2020

As is

  • Using Angular
  • Make a service request, throw a 500HttpErrorResponse
  • Report this error with StackdriverErrorHandler
  • Get a 400 from the service, error never reported

These errors do not have a stack trace, so the payload sent to the clouderrorreporting api was:

{
  "serviceContext": { "service": "my-service" },
  "context": {
    "httpRequest": {
      "userAgent": "Mozilla/5.0 ...",
      "url": "http://localhost:3000/app/123"
    }
  },
  "message": "Error extracting stack trace: Error: Cannot parse given Error object\n[object Object]\n    (::)"
}

The service then responded with:

400 - ReportedErrorEvent.context must contain a location unless message contain an exception or stacktrace.

Expected

Errors without a stack would be serialized in a way to maintain as much information as possible.

It is surprising to send "Error extracting stack trace" instead of a message representing the error trying to be reported.

One quick fix I tried to implement was to JSON.stringify errors before reporting, those were rejected by the service as "too long".

Overall, would love if the client would do everything possible to ensure the error gets reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant